feat(skills): support isolated bootstrap directories - #261
Merged
Conversation
jsoncm
force-pushed
the
feat/isolated-skill-discovery
branch
from
August 13, 2026 07:41
3cdd709 to
cfac6be
Compare
jiahe0510
approved these changes
Aug 24, 2026
jiahe0510
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed cfac6be against the current main. This is safe to merge.
isolated_skill_dirsis opt-in, so the existing default Skill discovery behavior remains unchanged.- The implementation correctly delegates to the established bare-mode loader, limiting filesystem discovery to the explicitly supplied project roots while retaining bundled Skills.
- The bootstrap regression test verifies both sides of the boundary: the isolated root is included and workspace Skills are excluded.
- Existing
aion-skillscoverage already verifies that bundled Skills remain available in bare mode.
Validation completed on the exact merge tree:
cargo fmt --all -- --checkcargo clippy -p aion-agent --tests -- -D warningscargo test -p aion-agent- AionCore
aionui-ai-agentcompatibility check against this revision
No AionUI behavior changes until a host explicitly opts into the new builder method.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentBootstrap::isolated_skill_dirsfor hosts that must limit Skill discovery to explicitly supplied rootsVerification
cargo fmt --all --checkcargo test -p aion-agent isolated_skill_dirs_excludes_workspace_skills --libcargo clippy -p aion-agent --tests -- -D warningsAll checks above were run with the repository-pinned Rust 1.96.1 toolchain.