Skip to content

feat(skills): support isolated bootstrap directories - #261

Merged
jiahe0510 merged 1 commit into
iOfficeAI:mainfrom
jsoncm:feat/isolated-skill-discovery
Aug 24, 2026
Merged

feat(skills): support isolated bootstrap directories#261
jiahe0510 merged 1 commit into
iOfficeAI:mainfrom
jsoncm:feat/isolated-skill-discovery

Conversation

@jsoncm

@jsoncm jsoncm commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • add AgentBootstrap::isolated_skill_dirs for hosts that must limit Skill discovery to explicitly supplied roots
  • preserve bundled-Skill availability and the existing default discovery behavior
  • cover workspace exclusion with a bootstrap-level test

Verification

  • cargo fmt --all --check
  • cargo test -p aion-agent isolated_skill_dirs_excludes_workspace_skills --lib
  • cargo clippy -p aion-agent --tests -- -D warnings

All checks above were run with the repository-pinned Rust 1.96.1 toolchain.

@jsoncm
jsoncm force-pushed the feat/isolated-skill-discovery branch from 3cdd709 to cfac6be Compare August 13, 2026 07:41

@jiahe0510 jiahe0510 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed cfac6be against the current main. This is safe to merge.

  • isolated_skill_dirs is opt-in, so the existing default Skill discovery behavior remains unchanged.
  • The implementation correctly delegates to the established bare-mode loader, limiting filesystem discovery to the explicitly supplied project roots while retaining bundled Skills.
  • The bootstrap regression test verifies both sides of the boundary: the isolated root is included and workspace Skills are excluded.
  • Existing aion-skills coverage already verifies that bundled Skills remain available in bare mode.

Validation completed on the exact merge tree:

  • cargo fmt --all -- --check
  • cargo clippy -p aion-agent --tests -- -D warnings
  • cargo test -p aion-agent
  • AionCore aionui-ai-agent compatibility check against this revision

No AionUI behavior changes until a host explicitly opts into the new builder method.

Approved.

@jiahe0510
jiahe0510 merged commit f711174 into iOfficeAI:main Aug 24, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants