Conversation
Co-authored-by: Alex Dunae <alex@dunae.ca>
…nents with updated view mode and action logging
…ents with new sort options handling
…nents with controlled sort options
…ponents to use new sort options structure
…ientSideIModelSort function
…ions and onSortOptionsChange for controlled sorting
…IModelTableMUI.tsx Co-authored-by: Alex Dunae <alex@dunae.ca>
…TwinGrid and IModelTable interfaces
…vorites and recents
alexdunae
left a comment
There was a problem hiding this comment.
Working great in my local testing 💪
…IModelGridMUI.tsx Co-authored-by: Alex Dunae <alex@dunae.ca>
…IModelGridMUI.tsx Co-authored-by: Alex Dunae <alex@dunae.ca>
…handling in IModelGridInternal
How are we going to know when someone else starts consuming the MUI components? |
There was a problem hiding this comment.
Sort breaks when trying to sort by a hidden column.
{
"hideColumns": [
"ITwinName"
]
}I'm not sure the sort column chip should appear if that column is being hidden, that could be implementation specific.
But aside from that, the records are not sorted by name in the above case, if I unhide the column:
Not sure if this is just the storybook implementation, or if it traces back to the component.
@ben-polinsky Grrr... actually a tough question. I've done a search internally and found one consumer, but of course there is no actual way to know about public usage. The internal consumer would be unaffected by this change. |
It's absolutely a "grr..." :) Anyway, I think we're okay for these changes - perhaps we could mark the components as beta and subject to change? I don't want to hold up this PR any longer, but do think it's worth discussing moving forward. |
|
@ben-polinsky agreed - we added |
ben-polinsky
left a comment
There was a problem hiding this comment.
hmm, I wasnt able to reproduce that, if i hide a column and sort by that column using the chips, im still getting the proper sorting.
Fair enough. I was on the fence about holding this up for this "issue" anyway. Not sure what I was doing wrong, but appreciate you checking it out.
|
Fixed the flaky test in manage-versions that was failing unrelated to my changes in this PR |



Added the ability to control the sorting of the tables through props.
