Remove @bentley/icons-generic from test-app - #1613
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The dependency removal is complete (no remaining @bentley/icons-generic references found) and all replaced icon usages resolve to existing local assets or iTwinUI icon components.
Pull request overview
This PR removes the @bentley/icons-generic package from the workspace (notably apps/test-app) by eliminating remaining imports of Bentley-generic SVGs and replacing them with iTwinUI icon components or local assets, and cleaning up now-unused SVG/tool code.
Changes:
- Removed
@bentley/icons-genericfrom the workspace catalog, lockfile, and affected package dependencies. - Replaced usages of Bentley-generic/custom SVG imports with
@itwin/itwinui-icons-reacticons (and a local Storybook placeholder asset). - Deleted unused tools and SVG assets that were only supporting the removed icon usage.
File summaries
| File | Description |
|---|---|
| pnpm-workspace.yaml | Removes @bentley/icons-generic from the workspace catalog. |
| pnpm-lock.yaml | Updates lockfile to remove @bentley/icons-generic entries across importers/packages. |
| docs/storybook/src/components/ToolbarComposer.stories.tsx | Switches placeholder SVG import to a local Storybook asset. |
| docs/storybook/package.json | Drops @bentley/icons-generic dependency from Storybook package. |
| apps/test-providers/src/ui/providers/CustomContentStageUiProvider.tsx | Replaces custom SVG icon usage with an iTwinUI icon component. |
| apps/test-providers/src/ui/icons/visibility-semi-transparent.svg | Removes unused custom SVG asset. |
| apps/test-providers/src/ui/icons/connected-query.svg | Removes unused custom SVG asset. |
| apps/test-providers/src/tools/ToolWithDynamicSettings.tsx | Replaces custom SVG tool icon with an iTwinUI icon via ToolUtilities.defineIcon. |
| apps/test-providers/src/tools/SampleTool.tsx | Replaces custom SVG tool icon with an iTwinUI icon via ToolUtilities.defineIcon. |
| apps/test-providers/src/tools/SampleTool.svg | Removes unused custom SVG tool icon asset. |
| apps/test-providers/src/tools/OpenSynchronizedViewTool.tsx | Replaces Bentley-generic SVG icon with iTwinUI icon via ToolUtilities.defineIcon. |
| apps/test-providers/src/tools/OpenPopoutViewTool.tsx | Replaces Bentley-generic SVG icon with iTwinUI icon via ToolUtilities.defineIcon. |
| apps/test-providers/src/tools/OpenPopoutDialogTool.tsx | Replaces Bentley-generic SVG icon with iTwinUI icon via ToolUtilities.defineIcon. |
| apps/test-providers/src/tools/OpenCustomDialogTool.tsx | Replaces custom SVG icon with iTwinUI icon via ToolUtilities.defineIcon. |
| apps/test-providers/src/tools/InspectUiItemInfoTool.tsx | Replaces Bentley-generic SVG icon with iTwinUI icon via ToolUtilities.defineIcon. |
| apps/test-providers/src/tools/GenericLocateTool.ts | Removes unused tool that depended on custom SVG icon. |
| apps/test-providers/src/tools/generic-tool.svg | Removes unused custom SVG tool icon asset. |
| apps/test-providers/src/tools/DynamicTool.svg | Removes unused custom SVG tool icon asset. |
| apps/test-providers/src/tools/ContentLayoutTools.tsx | Replaces Bentley-generic SVG icons with iTwinUI icons via ToolUtilities.defineIcon. |
| apps/test-providers/src/appui-test-providers.ts | Stops exporting the removed GenericLocateTool. |
| apps/test-providers/public/locales/en/AppuiTestProviders.json | Removes localization entries for the removed tool. |
| apps/test-providers/package.json | Drops @bentley/icons-generic dependency from test-providers package. |
| apps/test-app/src/frontend/appui/icons/rotate.svg | Removes unused custom SVG asset. |
| apps/test-app/src/frontend/appui/icons/filter.svg | Removes unused custom SVG asset. |
| apps/test-app/src/frontend/appui/icons/filter-outlined.svg | Removes unused custom SVG asset. |
| apps/test-app/src/frontend/appui/icons/draw.svg | Removes unused custom SVG asset. |
| apps/test-app/package.json | Drops @bentley/icons-generic dependency from test-app package. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 17/28 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Extracted from #1587
This PR removes custom SVG usage from
test-app:Testing
N/A