fix(adopt): match byte-for-byte hand copies during adoption - #22
Open
iagodahlem wants to merge 1 commit into
Open
fix(adopt): match byte-for-byte hand copies during adoption#22iagodahlem wants to merge 1 commit into
iagodahlem wants to merge 1 commit into
Conversation
collectDirFiles was called with skipRootMeta on the registry side but not on the working-copy side, so a workspace whose skills/<name>/ tree still carried module.json or CHANGELOG.md (the natural result of copying a registry module by hand) failed the equality check before its actual content was ever compared, landing in "differing" instead of "adopted".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Symmetric metadata skip: the working-copy side of the byte-match comparison now passes the same
skipRootMetaoption as the registry side, so a workspace whose skill tree still carriesmodule.json/CHANGELOG.md(the natural result of copying a registry module by hand) is compared on its actual content instead of failing on a file-count mismatch first.Regression test: added a case that hand-copies a registry module verbatim, metadata files included, and asserts the workspace lands in
adopted, notdiffering; confirmed the test fails against the old code and passes against the fix.Test plan
pnpm typecheck && pnpm lint && pnpm testall green (277/277 tests passing)adopts a hand-copied working tree that still carries registry metadata filesreproduces the bug against the old code and passes against the fixtests/integration/init-adopt.test.ts) still passes unchanged