refactor(actor): finish the Ffi→Wasm guest sdk rename#2091
Draft
iamacoffeepot wants to merge 1 commit into
Draft
refactor(actor): finish the Ffi→Wasm guest sdk rename#2091iamacoffeepot wants to merge 1 commit into
iamacoffeepot wants to merge 1 commit into
Conversation
Renames ErasedFfiActor → ErasedWasmActor, ComponentHostFfiExt → ComponentHostWasmExt, TcpFfiExt → TcpWasmExt, and moves the aether-actor/src/ffi/ module to src/wasm/. All crate::ffi:: and aether_actor::ffi:: paths update to wasm::. The six *_ffi.rs trybuild fixtures (+ .stderr siblings) rename to *_wasm.rs. ADR/guide mentions of ErasedFfiActor and the old module path update. Kept intact: the extern "C" imports in wasm/raw.rs, the _p32 ABI suffix, "Raw FFI boundary" comments, and the on-the-wire ABI symbol names (receive_p32, init, aether.kinds.inputs, aether.namespace). Closes #2090. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qodana for Rust4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
dispatch perf — latency — PR vs merge-base 76966ffbaseline 76966ff · 12 trials/config, interleaved on one runner 0 improved · 120 stable · 0 regressed (12 trials/config, paired) latency: no cells moved beyond the noise band. latency full grid — 120 cells
dispatch perf — heavy + real latency (trend) — PR vs merge-base 76966ffbaseline 76966ff · 6 trials/config (fidelity-capped), interleaved on one runner 0 improved · 0 stable · 0 regressed (6 trials/config, paired) latency.heavy — 96 cells, trend (no verdict)
keepup.real — 6 cells, keep-up (no verdict)
dispatch perf — throughput (saturation, backlog 512) — PR vs merge-base 76966ffbaseline 76966ff · 6 trials/config (fidelity-capped), interleaved on one runner 1 improved · 17 stable · 0 regressed (6 trials/config, paired)
throughput full grid — 18 cells
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
















































Closes #2090.
Summary
Finishes the Ffi→Wasm guest-SDK rename that #2089 began. #2089 moved the headline guest-facing types to
Wasm*but left a tail ofFfi-named symbols and theffi/module itself, leavingWasm*types living in a module whose own header documentedffias a deliberately generic-over-hosts name. This commits to the wasm framing — wasm32 is the only host — and moves the remaining guest-SDK surface toWasm:ErasedFfiActor→ErasedWasmActor(the object-safe boxed dual ofWasmActor; public, re-exported, and emitted by the#[actor]macro).ComponentHostFfiExt→ComponentHostWasmExt,TcpFfiExt→TcpWasmExt— keeping the existing wasm-vs-native transport axis the*NativeExtduals already use.aether-actor/src/ffi/→src/wasm/(pub mod ffi→pub mod wasm), with everycrate::ffi::/aether_actor::ffi::path updated acrossaether-actor,aether-capabilities, andaether-substrate. Thewasm/mod.rsheader is rewritten to present-tense wasm framing.FfiTransportdoc comments removed (the ZST was deleted in issue 665).*_ffi.rs(+.stderr) renamed to*_wasm.rs.The literal foreign-function boundary is kept as-is:
wasm/raw.rs'sextern "C"imports, the_p32ABI suffix, the "Raw FFI boundary" comments, and the on-the-wire ABI symbol names (receive_p32,init,aether.kinds.inputs,aether.namespace) — that boundary genuinely is FFI and is an on-the-wire contract the substrate's wasm runtime expects. No behavior change, no wire-format change.Test plan
Pure mechanical rename, validated by the existing suite —
cargo nextest run --workspace(2187 passed),cargo clippy --workspace --all-targets -- -D warnings,cargo doc --workspace --no-deps, the wasm32 component cross-builds, and the trybuild UI suite (whose.stderrgolden files embed the renamed fixture filenames). Fullscripts/preflight.shgreen.Generated by
/implement— agent execution of scoped issue #2090.