Import closed issues as terminal tasks (fixes #502)

[iamnbutler]

Summary

• issue_to_task() previously skipped all closed issues, so issues opened and closed between poll intervals (or before the first poll) were never imported as tasks
• Now closed issues are imported with the appropriate terminal state (Completed or Cancelled) based on their closure reason, reusing the same classify_closure() logic that reconcile_task uses
• Skip/ignore label checks still run first, so closed issues with tasks/skip or ignore labels are still excluded

Test plan

• Existing scheduler tests pass (38/38)
• New test: closed_issue_imported_as_terminal — completed issue → Completed state
• New test: closed_issue_not_planned_imported_as_cancelled — not-planned issue → Cancelled state
• New test: closed_issue_with_skip_label_not_imported — skip label still excludes closed issues

Fixes #502

🤖 Generated with Claude Code

[iamnbutler]

Orchestrator Evaluation: Rejected

The CI is explicitly marked as FAILING, which is a hard blocker. Beyond that, the code depends on issue.classify_closure() and tasks_github::model::ClosureReason which are not defined in the diff — if these types don't exist yet, that's the likely cause of the CI failure. The scheduler.rs changes themselves are logically sound: removing the early-return for closed issues, importing them as terminal tasks based on closure reason, and the tests cover the key cases. The run_loop.rs file shows that issue processing calls issue_to_task() and then does upsert logic, so the scheduler change alone should be sufficient for the import path — the reconciliation path already handles closed issues for existing tasks. However, with failing CI, this cannot be approved.

---

Feedback for agent:
CI is failing — this is a hard blocker. The most likely cause is that issue.classify_closure() and/or tasks_github::model::ClosureReason / IssueStateReason types referenced in the diff don't exist in the tasks_github crate (they aren't part of this diff). You need to either: (1) add the classify_closure() method and ClosureReason enum to the tasks_github crate, or (2) implement the closure classification inline in scheduler.rs using existing fields like issue.state and issue.state_reason. Fix CI before re-submitting.

[iamnbutler]

Orchestrator Evaluation: Rejected

CI is failing, which is a hard blocker. Beyond that, the diff relies on issue.classify_closure() and tasks_github::model::ClosureReason which are not shown in the diff — these types/methods must already exist in the tasks_github crate or be added by another PR. Neither of the queued PRs (#728, #706) appear to add these, and both are rejected. If classify_closure() and ClosureReason don't exist yet, this PR won't compile, which would explain the CI failure. The logical approach in the diff is sound — removing the early-return skip for closed issues, then classifying them into terminal states — but it cannot merge with failing CI and potentially missing dependencies.

---

Feedback for agent:

1. CI is failing — this is a hard blocker. Do not merge with failing CI.
2. Missing dependency: The diff calls issue.classify_closure() and references tasks_github::model::ClosureReason, but neither this diff nor any PR in the merge queue introduces these types/methods. If they don't already exist in the codebase, this is likely the cause of the CI failure. You need to either (a) add classify_closure() and ClosureReason to the tasks_github crate in this PR, or (b) depend on a separate PR that adds them and ensure it merges first.
3. Consistency note: pr_to_task() (line 147-149) still skips closed/merged PRs with an early return. The issue description only mentions issues, so this may be intentional, but it's worth considering whether the same gap exists for PRs.