Skip to content

beautify code#15

Open
kerolloz wants to merge 1 commit into
iamshaunjp:lesson-5from
kerolloz:lesson-5
Open

beautify code#15
kerolloz wants to merge 1 commit into
iamshaunjp:lesson-5from
kerolloz:lesson-5

Conversation

@kerolloz
Copy link
Copy Markdown

@kerolloz kerolloz commented May 1, 2019

No description provided.

Comment thread package.json
"dependencies": {
"express": "^4.15.2",
"socket.io": "^1.7.3"
"socket.io": "^2.2.0"
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated socket.io version

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of vulnerabilities in the old version

Comment thread public/chat.js
btn = document.getElementById('send'),
output = document.getElementById('output'),
feedback = document.getElementById('feedback');
handle = document.getElementById('handle'),
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed indentation

Comment thread public/chat.js
message.addEventListener('keypress', function () {
socket.emit('typing', handle.value);
})
});
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added missing simicolon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant