Skip to content

Using the new IBufferedFileStream class for faster game saving. - #44

Open
intorr wants to merge 1 commit into
ianpatt:masterfrom
intorr:master
Open

Using the new IBufferedFileStream class for faster game saving.#44
intorr wants to merge 1 commit into
ianpatt:masterfrom
intorr:master

Conversation

@intorr

@intorr intorr commented Oct 4, 2024

Copy link
Copy Markdown

Paired pull request for ianpatt/common#6

@AlexanderKomi

Copy link
Copy Markdown

There is this SKSE mod which honors this pull request: https://www.nexusmods.com/skyrimspecialedition/mods/163969

I think it would be a good idea to merge this for faster loading in generell.

@intorr

intorr commented Jun 19, 2026

Copy link
Copy Markdown
Author

I looked at the source code for this plugin.
I'm not sure I'm qualified enough to rewrite all the algorithms it uses from D to C++.
The only truly interesting thing I saw there was the parallel loading/saving of plugin data.
But is this really necessary?
Parallelism is interesting and can speed up data processing, but it also carries a lot of risk.
With the thousands of records that plugins write in cosave, I don't notice any slowdown when saving or loading the game.
How much will parallel processing speed up saving and loading?
I don't think the increased code complexity is worth it.

@AlexanderKomi

Copy link
Copy Markdown

Ok, thanks for taking a look at the plugin.
I think its a healthy approach to exclude unnecessary complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants