Clean up codebase and add integration tests#10
Merged
Conversation
Remove unused jinja2 dependency, dead create_pyproject_toml function and its template. Simplify __init__.py by dropping the Python <3.8 fallback. Fix validate_project_name to accept single-char names. Tighten requires-python to >=3.11 and modernize type hints. Fix setup_ruff to skip appending [tool.ruff] when it already exists. Replace Cursor-specific .mdc rule with cross-tool AGENTS.md. Align ruff target-version with .python-version (py313). Update pre-commit ruff hook to v0.11.10 and fix pytest hook to use uv run. Fix misleading test mocks to use valid questionary choices.
Add a base_dir parameter to initialize_project() so tests can control where generated projects land. Create three integration tests covering full-feature, minimal, and Cursor IDE configurations. Register the integration pytest marker in pyproject.toml.
iantimmis
force-pushed
the
feat/integration-tests
branch
from
e2f2078 to
0f44f01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jinja2dependency, deadcreate_pyproject_toml()function, and its template file__init__.pyby dropping the Python <3.8 fallback, tightenrequires-pythonto>=3.11, and modernize type hintsvalidate_project_nameregex to accept single-character namessetup_ruffto skip appending[tool.ruff]when it already exists.mdcrule with cross-toolAGENTS.mdtarget-versionwith.python-version(py313) and update pre-commit ruff hook tov0.11.10base_dirparameter toinitialize_project()and create three end-to-end integration tests covering full-feature, minimal, and Cursor IDE configurationsTest plan
uv run pytest -v)uv run pytest -m integrationruns only the 3 integration testsuv run pytest -m "not integration"skips them