fix to enable retrieving portfolios from multiple accounts#165
Open
cantupaz wants to merge 3 commits intoib-api-reloaded:mainfrom
Open
fix to enable retrieving portfolios from multiple accounts#165cantupaz wants to merge 3 commits intoib-api-reloaded:mainfrom
cantupaz wants to merge 3 commits intoib-api-reloaded:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes Issue #72
There seems to be a problem with IB API where it sends a generic accountDownloadEnd signal in response to a reqAccountUpdatesAsync. If we have multiple accounts and we send multiple simultaneous requests, something breaks when we receive the generic End signal, resulting in empty portfolios being returned when we call portfolio(). The solution is to subscribe to each account serially when we establish the connection.