You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I hope this satisfies #32, only added types from what I can understand of the code at the moment. Will push updates as soon as I learn more about the structure of the data being used internally.
So I tested the code a bit, and it seems to me that are many types missing. For example, "CollectContent" class doesn't have any type associated with it.
Also, there are "incomplete types", like RootConfig: export type RootConfig = { // Look at the pagination API for more details. pagination?: any; getPageData?: Function; getHtml?:Function // Receives a dictionary of children, and an address argument getPageObject?: Function; // Receives an axiosResponse object getPageResponse?: Function; // Receives htmlString and pageAddress getPageHtml?: Function; // Listens to every exception. Receives the Error object. getException?: (error: Error) => Promise<any>; } & HttpOperationConfig;
The "Function" type doesn't specify parameters and return value. This raises an error in my typescript client code.
Also, RootConfig seems to be missing "getHtml" hook.
What version and configuration of Typescript are you using? Perhaps it's less strict?
Yes, there are tons of missing types. I am using VSCode's bundled TS which is 5.2.2, maybe we could setup a tsconfig.json to explicitly include strict type checking. Gonna make some time for it this weekend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this satisfies #32, only added types from what I can understand of the code at the moment. Will push updates as soon as I learn more about the structure of the data being used internally.