Consider the --interface argument when broadcasting for scheduler discovery#544
Open
torokati44 wants to merge 1 commit intoicecc:masterfrom
Open
Consider the --interface argument when broadcasting for scheduler discovery#544torokati44 wants to merge 1 commit intoicecc:masterfrom
torokati44 wants to merge 1 commit intoicecc:masterfrom
Conversation
Contributor
|
The patch in principle looks good, but can you please make sure it's backwards source compatible (i.e. that icemon compiles without changes)? In some cases it's not necessary at all to pass the extra argument (e.g. DiscoverSched::sendSchedulerDiscovery() can use the member variable), in other cases it can be the last argument with a default value (which mostly will be also better API, with the argument not being very important in the argument list). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to (at least partially) solve #538.
It does not add any filtering for incoming packets, but at least the daemon won't look for schedulers on any interface other than the one given as command line argument (if one is given...).
It might not be perfect yet, because the naming of the new variables might be confusing here and there, and the value of the
--interfaceoption has to be passed around a lot in all sorts of places, but I'm open to suggestions for improvement.Maybe adding some comments would be enough to explain what the new variables/parameters are there for?
Also, this might break icemon.