Migrate Telemetry examples from Zipkin to OTLP#4558
Merged
pepone merged 4 commits intoicerpc:mainfrom Apr 27, 2026
Merged
Conversation
OpenTelemetry.Exporter.Zipkin 1.14.0 trips a NU1902 build break for GHSA-g94r-2vxg-569j (the vulnerability lives in a transitive OpenTelemetry.Api). The fix is in 1.15.x, which also marks AddZipkinExporter as obsolete. Replace OpenTelemetry.Exporter.Zipkin with OpenTelemetry.Exporter.OpenTelemetryProtocol 1.15.3 and use AddOtlpExporter. AddOtlpExporter defaults to http://localhost:4317 (gRPC), which the Jaeger all-in-one container accepts natively, so the README walks the reader through that container instead of running a separate Zipkin service. Drop the Zipkin UI screenshots that no longer apply.
There was a problem hiding this comment.
Pull request overview
Migrates the Telemetry examples away from the Zipkin exporter (which is now problematic due to security advisory + obsoletion warnings under TreatWarningsAsErrors) to the OTLP exporter, and updates the accompanying docs accordingly.
Changes:
- Replace
OpenTelemetry.Exporter.ZipkinwithOpenTelemetry.Exporter.OpenTelemetryProtocolin the Slice/Protobuf Telemetry client+server example projects. - Switch tracing export configuration from
AddZipkinExporter()toAddOtlpExporter(). - Update Telemetry READMEs to use a Jaeger all-in-one container and remove the Zipkin screenshot references (and drop the screenshots).
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/slice/Telemetry/zipkin.png | Removed obsolete Zipkin screenshot asset. |
| examples/slice/Telemetry/Server/Server.csproj | Swap Zipkin exporter package reference for OTLP exporter. |
| examples/slice/Telemetry/Server/Program.cs | Use AddOtlpExporter() and update comments to OTLP. |
| examples/slice/Telemetry/README.md | Update instructions to Jaeger + OTLP; remove Zipkin UI/screenshot references. |
| examples/slice/Telemetry/Client/Program.cs | Use AddOtlpExporter() and update comments to OTLP. |
| examples/slice/Telemetry/Client/Client.csproj | Swap Zipkin exporter package reference for OTLP exporter. |
| examples/protobuf/Telemetry/zipkin.png | Removed obsolete Zipkin screenshot asset. |
| examples/protobuf/Telemetry/Server/Server.csproj | Swap Zipkin exporter package reference for OTLP exporter. |
| examples/protobuf/Telemetry/Server/Program.cs | Use AddOtlpExporter() and update comments to OTLP. |
| examples/protobuf/Telemetry/README.md | Update instructions to Jaeger + OTLP; remove Zipkin UI/screenshot references. |
| examples/protobuf/Telemetry/Client/Program.cs | Use AddOtlpExporter() and update comments to OTLP. |
| examples/protobuf/Telemetry/Client/Client.csproj | Swap Zipkin exporter package reference for OTLP exporter. |
jaegertracing/all-in-one is the Jaeger v1 image, which reaches end-of-life on 2025-12-31 and prints a deprecation banner on every run. Use jaegertracing/jaeger (the unified binary image built on the OpenTelemetry Collector) instead. The OTLP and UI ports are unchanged so the rest of the README stays the same.
Use jaegertracing/jaeger:2.17.0 instead of :latest so users running the example get the exact image we tested against; a future v3 image that changes the UI or OTLP defaults won't silently shift the walkthrough out from under them.
The Telemetry example READMEs reference the Docker image jaegertracing/jaeger:2.17.0, which trips cspell. Add the term to the project dictionary so the spellcheck job stays green.
externl
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenTelemetry.Exporter.Zipkin 1.14.0trips aNU1902build break in CI for GHSA-g94r-2vxg-569j (vuln lives in a transitiveOpenTelemetry.Api). The fix is in 1.15.x, which also marksAddZipkinExporteras[Obsolete]— and the example projects useTreatWarningsAsErrors, so a plain bump turns the security warning into a deprecation error.OpenTelemetry.Exporter.ZipkinwithOpenTelemetry.Exporter.OpenTelemetryProtocol 1.15.3across the four Telemetry example projects (Slice + Protobuf, client + server) and useAddOtlpExporter.:4317natively and exposes the trace UI on:16686.zipkin.pngscreenshots.