Improve build release workflow#765
Merged
pepone merged 3 commits intoicerpc:mainfrom Apr 9, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions release workflow to upload build artifacts for more release qualities and to organize uploads using the slicec version metadata.
Changes:
- Expose both full slicec version and a derived “channel” value from
cargo metadatafor downstream jobs. - Upload artifacts for all qualities (not just nightly) when running in
icerpc/slicec. - Compute an S3 upload base path from quality + derived version “channel”, and use it for both S3 upload and CloudFront invalidation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
externl
approved these changes
Apr 9, 2026
| run: | | ||
| for file in artifacts/slicec-*.zip; do | ||
| aws s3 cp "$file" "s3://zeroc-downloads/icerpc/slicec/${{ inputs.quality }}/${{ needs.metadata.outputs.version }}/" | ||
| aws s3 cp "$file" "s3://zeroc-downloads/icerpc/${S3_PATH}/" |
Member
There was a problem hiding this comment.
I would move slicec into this part of the upload. and keep the rest in S3_PATH, or move everything (the whole URI) into S3_PATH.
InsertCreativityHere
approved these changes
Apr 9, 2026
Member
InsertCreativityHere
left a comment
InsertCreativityHere
left a comment
There was a problem hiding this comment.
Sounds good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small improvement to the release workflow: