Skip to content

Rework --generator Command Line Format#767

Merged
InsertCreativityHere merged 4 commits intoicerpc:mainfrom
InsertCreativityHere:change-generator-cli
Apr 10, 2026
Merged

Rework --generator Command Line Format#767
InsertCreativityHere merged 4 commits intoicerpc:mainfrom
InsertCreativityHere:change-generator-cli

Conversation

@InsertCreativityHere
Copy link
Copy Markdown
Member

This PR implements the changes outlined in #747 (comment).
If anyone has any other changes to request with the generator CLI, feel free to comment on that issue!

Otherwise, as-of this PR, I consider #747 as completed.


For the tooling, they will no longer need to replace \\ with /, but they still have to replace , with \, in the generator path.
This is sufficient for any generator to be parsed correctly by slicec.
Generators do not need to escape =. We don't ascribe any special meaning to = in the path, only in the arguments.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates slicec’s --generator command-line format to match the new proposal from issue #747, switching generator argument separation to a comma-based format and adjusting escaping rules accordingly.

Changes:

  • Reworked generator CLI parsing to use , as the path/argument separator and = within arguments, with \ used to escape , and = when needed.
  • Updated command-line parsing tests to cover trailing separators and the revised escaping behavior.
  • Adjusted validation/error messaging around missing keys/paths to align with the new format.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
slicec/src/slice_options.rs Updates the generator plugin parser to the new comma-separated format and adds validation for empty path / empty keys.
slicec/tests/command_line_tests.rs Updates and expands CLI parsing tests to reflect the new --generator syntax and escaping semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread slicec/src/slice_options.rs
Comment thread slicec/src/slice_options.rs
Comment thread slicec/src/slice_options.rs
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread slicec/src/slice_options.rs
Comment thread slicec/src/slice_options.rs
@InsertCreativityHere InsertCreativityHere merged commit 79831a8 into icerpc:main Apr 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants