Rework --generator Command Line Format#767
Merged
InsertCreativityHere merged 4 commits intoicerpc:mainfrom Apr 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates slicec’s --generator command-line format to match the new proposal from issue #747, switching generator argument separation to a comma-based format and adjusting escaping rules accordingly.
Changes:
- Reworked generator CLI parsing to use
,as the path/argument separator and=within arguments, with\used to escape,and=when needed. - Updated command-line parsing tests to cover trailing separators and the revised escaping behavior.
- Adjusted validation/error messaging around missing keys/paths to align with the new format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
slicec/src/slice_options.rs |
Updates the generator plugin parser to the new comma-separated format and adds validation for empty path / empty keys. |
slicec/tests/command_line_tests.rs |
Updates and expands CLI parsing tests to reflect the new --generator syntax and escaping semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pepone
approved these changes
Apr 10, 2026
externl
approved these changes
Apr 10, 2026
bernardnormier
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the changes outlined in #747 (comment).
If anyone has any other changes to request with the generator CLI, feel free to comment on that issue!
Otherwise, as-of this PR, I consider #747 as completed.
For the tooling, they will no longer need to replace
\\with/, but they still have to replace,with\,in the generator path.This is sufficient for any generator to be parsed correctly by
slicec.Generators do not need to escape
=. We don't ascribe any special meaning to=in the path, only in the arguments.