dev - last dance#67
Merged
Merged
Conversation
…ustes na geração e verificação
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request introduces several improvements and refinements across the backend and frontend, focusing on certificate generation, environment configuration, and frontend integration. The most significant changes include passing the coordinator's name to certificates, updating certificate layout and verification URLs to use the frontend, and enhancing test coverage and environment variable handling.
Certificate Generation and Layout:
coordenadorNome) is now included in the certificate, with a fallback if not found. The certificate PDF layout has been improved: it now features a double border, clearer header/body sections, a centered coordinator signature, and improved placement of the QR code and verification URL. The verification URL now points to the frontend/verificar/:hashroute instead of a backend API endpoint. [1] [2] [3] [4] [5] [6] [7]Backend Logic and Environment Configuration:
FRONTEND_URLenvironment variable (with fallback toCORS_ORIGIN) to generate verification URLs and QR codes, ensuring consistency with the deployed frontend. This variable is documented and used in.envexamples and Docker Compose. [1] [2] [3]Testing Enhancements:
Frontend Improvements:
Cadastro.tsx) now correctly resets or auto-selects the "turno" (shift) field when the course or available shifts change, improving user experience and preventing stale selections.Certificate Generation and Verification:
coordenadorNometo certificate data and PDF, with fallback if the coordinator is not found. [1] [2]FRONTEND_URLand point to/verificar/:hashon the frontend. [1] [2] [3]Configuration and Deployment:
FRONTEND_URLenvironment variable in backend, Docker Compose, and example.envfiles for both environments. [1] [2] [3]Testing:
Frontend: