feat(driver): add base driver - #4
Merged
Merged
Conversation
Contributor
Author
|
Me and Milad think that the template way is the best way to go, more clean and if something needs to be added it is easy. It still contains a lot of register so we like this version more. |
mirzak
requested changes
Nov 3, 2025
Dexter9532
force-pushed
the
new_driver
branch
from
November 3, 2025 12:16
b315d31 to
352ef1b
Compare
Dexter9532
force-pushed
the
new_driver
branch
from
November 3, 2025 17:01
00810b5 to
7582d1a
Compare
mirzak
requested changes
Nov 4, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
Also your commit body message contains typos,
dcm230 contains a both holding and input registers, this is why i add
want to add the check
Dexter9532
force-pushed
the
new_driver
branch
2 times, most recently
from
November 4, 2025 14:58
b0c4b4b to
effa319
Compare
mirzak
requested changes
Nov 6, 2025
mirzak
reviewed
Nov 6, 2025
Dexter9532
force-pushed
the
new_driver
branch
from
November 6, 2025 08:56
effa319 to
f51608d
Compare
Dexter9532
force-pushed
the
new_driver
branch
2 times, most recently
from
November 6, 2025 09:23
966120b to
93b0c5c
Compare
mirzak
requested changes
Nov 6, 2025
Dexter9532
force-pushed
the
new_driver
branch
from
November 6, 2025 10:43
93b0c5c to
ac17633
Compare
mirzak
previously approved these changes
Nov 6, 2025
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
Dexter9532
force-pushed
the
new_driver
branch
from
November 6, 2025 15:35
ac17633 to
6fd95e0
Compare
mirzak
previously approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.