Conversation
mirzak
left a comment
There was a problem hiding this comment.
Also your commits must be signed off, see https://stackoverflow.com/a/35238070/10612238. Related to #17
mirzak
left a comment
There was a problem hiding this comment.
Getting there. I have some more change requests though :)
Please close conversations if you have addressed the comment. This makes it easier for me to track.
Also still need to address #21 (review).
There was a problem hiding this comment.
I noted that you are using the wrong path for the workflows file. Because of this, your workflow is not running. You can not see it here: https://github.com/id8-engineering/python-em511/pull/21/checks.
You are using:
src/.github/workflows/pyright.yml
it should be:
.github/workflows/pyright.yml
And the final thing, you will need to fix your git history (one commit only).
0145142 to
1b255b5
Compare
0929176 to
68001f1
Compare
mirzak
left a comment
There was a problem hiding this comment.
Missing the Signed-off-by tag. You can run the following to add it:
git commit -s --amend
mirzak
left a comment
There was a problem hiding this comment.
You are still missing a sign-off tag in your commit. You can achieve this with:
git commit -s --amend
This will update your commit and add a signed-off tag. Push changes when you have done this.
Signed-off-by: Milad Makdesi <milad@id8-engineering.io>
closes #7