Skip to content

chore(CI): Add pyright - #21

Merged
mirzak merged 1 commit into
mainfrom
pyright
Oct 22, 2025
Merged

chore(CI): Add pyright#21
mirzak merged 1 commit into
mainfrom
pyright

Conversation

@MiladMakdesi

@MiladMakdesi MiladMakdesi commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

closes #7

@mirzak mirzak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also your commits must be signed off, see https://stackoverflow.com/a/35238070/10612238. Related to #17

Comment thread pyrightconfig.json Outdated
Comment thread src/.github/workflows/pyright.yml Outdated
Comment thread src/.github/workflows/pyright.yml Outdated
Comment thread src/.github/workflows/pyright.yml Outdated
Comment thread src/.github/workflows/pyright.yml Outdated
@MiladMakdesi
MiladMakdesi requested a review from mirzak October 20, 2025 09:39

@mirzak mirzak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there. I have some more change requests though :)

Please close conversations if you have addressed the comment. This makes it easier for me to track.

Also still need to address #21 (review).

Comment thread src/.github/workflows/pyright.yml Outdated
Comment thread src/.github/workflows/pyright.yml Outdated
Comment thread .github/workflows/pyright.yml Outdated
Comment thread pyrightconfig.json Outdated
@MiladMakdesi
MiladMakdesi requested a review from mirzak October 20, 2025 10:02

@mirzak mirzak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted that you are using the wrong path for the workflows file. Because of this, your workflow is not running. You can not see it here: https://github.com/id8-engineering/python-em511/pull/21/checks.

You are using:

src/.github/workflows/pyright.yml

it should be:

.github/workflows/pyright.yml

And the final thing, you will need to fix your git history (one commit only).

Comment thread src/.github/workflows/pyright.yml Outdated
Comment thread .github/workflows/pyright.yml Outdated
Dexter9532
Dexter9532 previously approved these changes Oct 21, 2025
@mirzak mirzak changed the title chore(CI): Add pyright.yml and pyrightconfig.json chore(CI): Add pyright Oct 21, 2025
Comment thread .github/workflows/pyright.yml Outdated
Comment thread .github/workflows/pytest.yml
@MiladMakdesi
MiladMakdesi force-pushed the pyright branch 3 times, most recently from 0929176 to 68001f1 Compare October 21, 2025 12:30
@MiladMakdesi
MiladMakdesi requested a review from mirzak October 21, 2025 12:32

@mirzak mirzak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the Signed-off-by tag. You can run the following to add it:

git commit -s --amend 

@mirzak mirzak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are still missing a sign-off tag in your commit. You can achieve this with:

git commit -s --amend

This will update your commit and add a signed-off tag. Push changes when you have done this.

Signed-off-by: Milad Makdesi <milad@id8-engineering.io>
@mirzak
mirzak merged commit b47928a into main Oct 22, 2025
20 checks passed
@mirzak
mirzak deleted the pyright branch October 22, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pyright workflow

3 participants