feat(em511): Add the driver with some functions - #27
Conversation
979ace3 to
0dc84a7
Compare
ca44418 to
c2b0dca
Compare
c2b0dca to
3f717f2
Compare
3f717f2 to
974443e
Compare
mirzak
left a comment
There was a problem hiding this comment.
Good start. We still have some work to do :).
50554e4 to
663511a
Compare
16378b7 to
39f3f3f
Compare
6770d3b to
484f2f4
Compare
484f2f4 to
33b8c46
Compare
33b8c46 to
a24463f
Compare
|
now everything should be as requested |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new driver for the Carlo Gavazzi EM511 energy meter with Modbus communication support. The implementation includes property-based access to voltage and current readings, as well as password management functionality.
- Implements the
Em511driver class with read/write operations for Modbus registers - Adds comprehensive test coverage for voltage, current, and password operations
- Replaces placeholder hello function with actual driver implementation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/em511/em511.py | Core driver implementation with Modbus register operations for EM511 energy meter |
| src/em511/test_em511.py | Unit tests covering voltage, current, and password read/write operations with edge cases |
| src/em511/init.py | Package initialization exposing the Em511 driver class |
| src/em511/test_hello.py | Removed placeholder test file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
849cce8 to
157d5e9
Compare
|
Great! I marked this as ready for review, which triggers a Copilot review. It found some spelling to fix. Before approving and merging we need to sort out the packaging. Right now if you run the following: To import the module I have to use : This means that is right now shipping the The desired end result is to be able to import using: |
|
PR #39 will fix this problem! |
mirzak
left a comment
There was a problem hiding this comment.
Can you rebase this on main and please update the commit message. Something along the lines of:
feat(em511): Add base driver
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
|
what do mean rebase this on main? |
157d5e9 to
235188a
Compare
|
commit is fixed! |
You already did it :). I mean to run |
|
ah yes i understand |
|
vammmooos |
also added some tests, should run!