Dependency pyproject - #28
Merged
Merged
Conversation
Dexter9532
force-pushed
the
dependency_pyproject
branch
from
October 21, 2025 14:30
b271b7d to
cff762a
Compare
mirzak
approved these changes
Oct 21, 2025
mirzak
requested changes
Oct 21, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
pymodbus already has a dependency on pyserial, https://github.com/pymodbus-dev/pymodbus/blob/dev/pyproject.toml#L44-L47.
Contributor
Author
|
I see, hmm thanks for noticing me! |
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
Dexter9532
force-pushed
the
dependency_pyproject
branch
from
October 22, 2025 07:32
cff762a to
9c72467
Compare
Contributor
Author
|
I have re opened this pull request, when i try uv sync on local with the changes i have made it works and without it does not. |
Contributor
Author
|
[project.optional-dependencies] |
mirzak
approved these changes
Oct 22, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
Nice find with the optional flag!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for my driver to be added!