chore(CI): Add row lenght - #30
Merged
Merged
Conversation
mirzak
requested changes
Oct 22, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
There is a typo in your commit title,
chore(CI): Add row lengh
While at it, I would write something like:
chore(ruff): Update maximum line length to 120 columns
did this because of row being to short.
Would also update above to:
The default maximum line length is 80 columns, which is rather aggressive with modern tools.
Dexter9532
force-pushed
the
pyproject_lengh
branch
from
October 23, 2025 06:48
c05d619 to
de3ba87
Compare
mirzak
requested changes
Oct 23, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
The commit message looks odd:
chore(CI): chore(ruff): Update maximum line length
to 120 columns
The default maximum line length is 80 columns, which is
rather aggressive with modern tools.
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
You have an unexpected line break in the title, and you have chore(CI): chore(ruff):. Just chore(ruff) is enough.
The default maximum line length is 80 columns, which is rather aggressive with modern tools. Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
Dexter9532
force-pushed
the
pyproject_lengh
branch
from
October 23, 2025 09:47
de3ba87 to
f19fbf3
Compare
mirzak
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did this because of row being to short.