Conversation
mirzak
requested changes
Oct 23, 2025
mirzak
requested changes
Oct 23, 2025
Contributor
There was a problem hiding this comment.
Change looks good!
Some remarks on your commit message,
- You have a typo,
dependecys->dependencies - We have so far used the convention of lower case conventional commit tags, lets try to be consistent. Your commit message begins with
Chore(pre-commit).
Also, please set appropriate pull-request title. If the pull-request has only one commit, the pull-request title is the same as the commit title.
mirzak
requested changes
Oct 23, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
One more thing, always use imperative language in commit titles.
chore(pre-commit): added additional dependencies should be chore(pre-commit): add additional dependencies
When we include module imports, pyright is not able to find them when running under pre-commit. Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
mirzak
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will make pyright test happy when testing driver file