feat: add register specifications for new functions - #45
Merged
Conversation
mirzak
requested changes
Oct 31, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
Changes looks (mostly) good, but I am missing tests for all new functions.
Contributor
|
Also remove trailing dot in commit title, |
MiladMakdesi
force-pushed
the
add_registers
branch
from
November 3, 2025 11:32
abe4410 to
7c49029
Compare
mirzak
requested changes
Nov 3, 2025
MiladMakdesi
force-pushed
the
add_registers
branch
from
November 3, 2025 12:35
7c49029 to
9f0ffa5
Compare
Contributor
|
You also still need to handle #45 (comment). |
MiladMakdesi
force-pushed
the
add_registers
branch
4 times, most recently
from
November 4, 2025 18:04
5ed8df4 to
5db9270
Compare
MiladMakdesi
changed the title
MiladMakdesi
force-pushed
the
add_registers
branch
from
November 5, 2025 07:06
5db9270 to
83d9493
Compare
Signed-off-by: Milad Makdesi <milad@id8-engineering.io>
mirzak
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.