WIP: New way of evaluating drum material properties for thermal conduction#790
Open
YaqiWang wants to merge 1 commit intoidaholab:develfrom
Open
WIP: New way of evaluating drum material properties for thermal conduction#790YaqiWang wants to merge 1 commit intoidaholab:develfrom
YaqiWang wants to merge 1 commit intoidaholab:develfrom
Conversation
Contributor
Author
|
Note that we do not save much number of input lines wise here because there is only one drum in this model and only two segments on the drum. It does make users avoid the mind boggling math in the functions. But in a full core case, we will have 12 drums and this change can help. |
YaqiWang
force-pushed
the
drum_thermal_prop
branch
from
8698da7 to
0d88a73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new material proposed in MOOSE (idaholab/moose#32773) is still under review. I also need to run the model to make sure the correctness of the change.