Skip to content

Updated README - #21

Merged
d-ruiz merged 2 commits into
idempiere:mainfrom
deanpretorius:main
Mar 16, 2026
Merged

d-ruiz merged 2 commits into
idempiere:mainfrom
deanpretorius:main

Conversation

@deanpretorius

@deanpretorius deanpretorius commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Edited README.md

Provided detailed steps of editing documentation using Github Interface.
Minor formatting to Readme.md

Summary by CodeRabbit

  • Documentation
    • Condensed editing rationale and added a dedicated GitHub workflow section with step-by-step guidance and illustrative images
    • Clarified that GitHub Pages does not support direct in-page editing and reworded instructions to follow the outlined workflow
    • Expanded and reorganized the fork/edit/commit/PR sequence with numbered steps and image-supported guidance

Clarified the process for making edits via GitHub and added detailed steps for using the GitHub interface.
@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

README.md updated to replace an inline editing explanation with a condensed rationale and a step-by-step GitHub editing workflow (navigate, edit, fork/commit, view changes, create PR) including image references and a note that GitHub Pages cannot be edited from rendered pages.

Changes

Cohort / File(s) Summary
Documentation
README.md
Rewrote GitHub editing guidance into a numbered, image‑supported workflow: navigate to repo, edit file, fork/commit, view changes, create PR. Clarified GitHub Pages limitation and removed previous inline web‑UI edit phrasing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇✨
I nibbled words and stitched a trail,
Steps and pics to catch the tail.
Fork, edit, commit — hop to PR light,
Docs now glow, concise and bright! 🥕📸

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Updated README' is vague and generic, using non-descriptive language that doesn't convey the specific nature of the changes made to the documentation. Consider a more specific title like 'Add GitHub workflow documentation with step-by-step editing guide' to clearly indicate the primary change to the README.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Line 20: Replace all occurrences of the incorrect capitalization "Github" with
the correct "GitHub" in the README section titled "## Github Interface" (and any
other occurrences of the word "Github" in that file), ensuring the heading text
and inline mentions use "GitHub" consistently; search for the exact token
"Github" and update each instance to "GitHub" so the section title and
references match proper branding.
- Around line 33-34: The sentence "Copilot will generate a commit message for
your edits" should be made non-mandatory—update the wording in the README (the
sentence in the commit step) to present Copilot-generated commit messages as an
optional fallback (e.g., "Copilot can generate a commit message for your edits"
or "You may use Copilot to generate a commit message"), so the instruction is
accurate for all users and accounts.
- Around line 15-16: Replace the pseudo-comment text "// Github pages does not
allow direct editing of the pages." with a normal sentence and correct platform
casing to "GitHub"; update the sentence in README.md (the line starting with "//
Github pages does not allow direct editing of the pages.") so it reads as plain
Markdown (e.g., "GitHub Pages does not allow direct editing of pages via the web
interface; here is how to edit pages through GitHub.") to avoid rendering
confusion and normalize the platform name.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 27483670-2d38-40f1-9b43-b01285f30d34

📥 Commits

Reviewing files that changed from the base of the PR and between eb41ad5 and 7a99908.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md
Comment on lines +33 to +34
4. Copilot will generate a commit message for your edits. Click "Proceed" to accept the edits, and commit them to your forked repository:
<img width="815" height="763" alt="image" src="https://github.com/user-attachments/assets/660740d4-2001-4489-9844-1f7f3b44fa61" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Avoid making Copilot behavior sound mandatory.

On Line 33, “Copilot will generate a commit message” may not apply to all users/accounts. Suggest wording this as optional fallback so the instructions remain accurate for everyone.

Suggested edit
-4. Copilot will generate a commit message for your edits. Click "Proceed" to accept the edits, and commit them to your forked repository:
+4. GitHub may suggest a commit message (and Copilot may assist, if enabled). Review or edit the message, then click "Proceed" to commit to your forked repository:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
4. Copilot will generate a commit message for your edits. Click "Proceed" to accept the edits, and commit them to your forked repository:
<img width="815" height="763" alt="image" src="https://github.com/user-attachments/assets/660740d4-2001-4489-9844-1f7f3b44fa61" />
4. GitHub may suggest a commit message (and Copilot may assist, if enabled). Review or edit the message, then click "Proceed" to commit to your forked repository:
<img width="815" height="763" alt="image" src="https://github.com/user-attachments/assets/660740d4-2001-4489-9844-1f7f3b44fa61" />
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 33 - 34, The sentence "Copilot will generate a commit
message for your edits" should be made non-mandatory—update the wording in the
README (the sentence in the commit step) to present Copilot-generated commit
messages as an optional fallback (e.g., "Copilot can generate a commit message
for your edits" or "You may use Copilot to generate a commit message"), so the
instruction is accurate for all users and accounts.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (2)
README.md (2)

20-20: ⚠️ Potential issue | 🟡 Minor

Use consistent “GitHub” branding in all edited lines.

Please change Github/github to GitHub on Line 20, Line 29, and Line 36 for correctness and consistency.

Suggested edit
-## Github Interface
+## GitHub Interface
...
-3. This button creates a fork of the repository linked to your personal github account, and opens the file you indicated you wish to edit.
+3. This button creates a fork of the repository linked to your personal GitHub account, and opens the file you indicated you wish to edit.
...
-5. Github will display all the changes you have committed. Confirm the changes you are proposing, and click "Create Pull Request".
+5. GitHub will display all the changes you have committed. Confirm the changes you are proposing, and click "Create Pull Request".

Also applies to: 29-29, 36-36

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` at line 20, Update the branding to use the correct "GitHub"
casing: replace the heading text "## Github Interface" and the other occurrences
"Github" / "github" mentioned in the review with "GitHub" (ensure the exact
capitalization) so all three instances (the heading and the two other
occurrences called out) consistently use "GitHub".

33-34: ⚠️ Potential issue | 🟡 Minor

Don’t make Copilot-generated commit messages sound mandatory.

On Line 33, “Copilot will generate…” may not apply to every user/account. Please phrase this as optional.

Suggested edit
-4. Copilot will generate a commit message for your edits. Click "Proceed" to accept the edits, and commit them to your forked repository:
+4. GitHub may suggest a commit message (and Copilot may assist, if enabled). Review or edit the message, then click "Proceed" to commit to your forked repository:
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 33 - 34, Change the sentence "Copilot will generate a
commit message for your edits. Click 'Proceed' to accept the edits, and commit
them to your forked repository:" to optional language so it doesn't sound
mandatory—e.g., reword to "Copilot can generate a commit message for your edits;
you may click 'Proceed' to accept the edits and commit them to your forked
repository." Update the README.md sentence (the one beginning "Copilot will
generate a commit message for your edits") accordingly.
🧹 Nitpick comments (1)
README.md (1)

13-13: Tighten redundant wording in the PR sentence.

Line 13 repeats “perform” and reads awkwardly. A small rewrite will improve clarity.

Suggested edit
-Since most users cannot directly commit to the repository, you will need to perform a pull request to perform edits.
+Since most users cannot commit directly to this repository, you’ll need to submit a pull request for edits.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` at line 13, The sentence "Since most users cannot directly commit
to the repository, you will need to perform a pull request to perform edits." is
redundant; rewrite it to remove the repeated "perform" and improve clarity by
replacing it with a single, concise phrasing — for example: "Since most users
cannot commit directly to the repository, you must open a pull request to make
edits." Update the README sentence accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@README.md`:
- Line 20: Update the branding to use the correct "GitHub" casing: replace the
heading text "## Github Interface" and the other occurrences "Github" / "github"
mentioned in the review with "GitHub" (ensure the exact capitalization) so all
three instances (the heading and the two other occurrences called out)
consistently use "GitHub".
- Around line 33-34: Change the sentence "Copilot will generate a commit message
for your edits. Click 'Proceed' to accept the edits, and commit them to your
forked repository:" to optional language so it doesn't sound mandatory—e.g.,
reword to "Copilot can generate a commit message for your edits; you may click
'Proceed' to accept the edits and commit them to your forked repository." Update
the README.md sentence (the one beginning "Copilot will generate a commit
message for your edits") accordingly.

---

Nitpick comments:
In `@README.md`:
- Line 13: The sentence "Since most users cannot directly commit to the
repository, you will need to perform a pull request to perform edits." is
redundant; rewrite it to remove the repeated "perform" and improve clarity by
replacing it with a single, concise phrasing — for example: "Since most users
cannot commit directly to the repository, you must open a pull request to make
edits." Update the README sentence accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 43302701-5670-4f0f-baa5-6c4fe1d43b86

📥 Commits

Reviewing files that changed from the base of the PR and between 7a99908 and 6713bbf.

📒 Files selected for processing (1)
  • README.md

@d-ruiz
d-ruiz merged commit 8c7d0da into idempiere:main Mar 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants