Skip to content

IDEMPIERE-6908 Implement iDempiere Extension Management - #26

Merged
d-ruiz merged 2 commits into
idempiere:mainfrom
hengsin:IDEMPIERE-6908_filerepo
May 29, 2026
Merged

d-ruiz merged 2 commits into
idempiere:mainfrom
hengsin:IDEMPIERE-6908_filerepo

Conversation

@hengsin

@hengsin hengsin commented May 21, 2026

Copy link
Copy Markdown
Contributor
  • add notes for file: repository support

Summary by CodeRabbit

  • Documentation
    • Updated extension repository configuration docs to show support for local file URLs (file:///) in addition to remote repositories.
    • Clarifies how to point the extension repository at a local file-based repository, enabling local development and testing workflows.

Review Change Stack

- add notes for file: repository support
@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 78e871ff-f5c7-4098-ba27-a39199665433

📥 Commits

Reviewing files that changed from the base of the PR and between a775a73 and 31169ab.

📒 Files selected for processing (1)
  • docs/new-features/v14/extension-management.md
✅ Files skipped from review due to trivial changes (1)
  • docs/new-features/v14/extension-management.md

📝 Walkthrough

Walkthrough

This PR updates extension management documentation to clarify that the IDEMPIERE_EXTENSION_REPOSITORY system property supports file:///.../extension-repository/ local paths for development and testing in addition to remote repository URLs.

Changes

Extension Repository Configuration Documentation

Layer / File(s) Summary
Local file path repository option documentation
docs/new-features/v14/extension-management.md
Adds a note clarifying that IDEMPIERE_EXTENSION_REPOSITORY can use file:///.../extension-repository/ paths for local development and testing, instead of only supporting remote GitHub-hosted repositories.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • idempiere/idempiere.github.io#22: Updates the same extension management documentation page by extending the IDEMPIERE_EXTENSION_REPOSITORY system property configuration details with local file path examples.

Poem

🐰 A file path blooms where URLs grew,
file:/// for testing, shiny and new,
Local repos quiet, ready to play,
Docs whisper: "Run your dev this way,"
Hops of joy in every build anew.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'IDEMPIERE-6908 Implement iDempiere Extension Management' is overly broad and doesn't match the actual change, which only adds configuration notes for file:// repository support in documentation. Update the title to reflect the actual change, such as 'Add file:// repository configuration notes for IDEMPIERE-6908' or 'Document local file repository support for extension management'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/new-features/v14/extension-management.md`:
- Line 48: Fix the grammar and capitalization in the configuration note that
mentions IDEMPIERE_EXTENSION_REPOSITORY: change "instead of remote repository
hosted at github.com." to "instead of a remote repository hosted at GitHub.com."
so it includes the missing article "a" and properly capitalizes "GitHub"
(reference string: IDEMPIERE_EXTENSION_REPOSITORY /
"file:///path/to/your/extension-repository/").
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 903f46b7-0338-4066-84b6-effb0d59ae74

📥 Commits

Reviewing files that changed from the base of the PR and between 669e15b and a775a73.

📒 Files selected for processing (1)
  • docs/new-features/v14/extension-management.md

Comment thread docs/new-features/v14/extension-management.md Outdated
@d-ruiz
d-ruiz merged commit d2c83b3 into idempiere:main May 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants