Conversation
Author
|
Now all code is in proper places, PR is ready for review |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the time when someone wants to use a prover in browser, they also want to calculate witness in browser too. I've added witness calculation by pulling only small subset of snarkjs, and added it in the same way as previous
genZKSnarkProoffunction. It also outputs public snark inputs with the proof. In addition there is a small functionzkSnarkProofToSolidityInputthat converts the proof to format solidity verifier expects.I've added all my code to main.js put probably some parts of it should be moved to other places.