Fix epoch reward calculation bug and improve test coverage#6
Open
dmrdvn wants to merge 2 commits intoidos-network:masterfrom
Open
Fix epoch reward calculation bug and improve test coverage#6dmrdvn wants to merge 2 commits intoidos-network:masterfrom
dmrdvn wants to merge 2 commits intoidos-network:masterfrom
Conversation
- fix critical bug in reward calculation using upperLookup correctly - convert require statements to if+revert for custom error support - add unchecked blocks to loops for gas optimization (~3 gas per iteration) - remove unused imports (Arrays, Math) - update solidity version to 0.8.27 for consistency gas improvements: - stake: -24 gas (-0.007%) - unstake: -32 gas (-0.017%) - withdrawReward(30 epochs): -90 gas (-0.017%)
- add 18 new test cases covering security, edge cases, and multi-user scenarios - add reentrancy protection tests - add maximum value handling tests - add gas benchmark suite for tracking optimization impact - test coverage increased from 49 to 67 tests (+37%) all tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a critical bug in the epoch reward calculation and adds comprehensive test coverage to improve contract security and reliability.
Changes
Contract Improvements
upperLookup()for each epochrequire()statements toif + revertpatternuncheckedblocks to 9 loops (~3 gas saved per iteration)Test Enhancements
Gas Impact
stake(): -24 gas (-0.007%)unstake(): -32 gas (-0.017%)withdrawReward(30 epochs): -90 gas (-0.017%)Testing
All 67 tests passing ✅