Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ Phases 1–3b are complete. The `<latency-test>` Custom Element is implemented w
- `worker.js` cross-correlates two buffers: in the audioworklet path these are `{ mic, ref }` Float32 PCM; in the mediarecorder (2ch) path these are `ch0` (mic) and `ch1` (reference) from the decoded stereo recording; in the mediarecorder-1ch path these are the decoded mono recording vs the pre-generated MLS AudioBuffer

**Still in progress:**
- Phase 6: framework example end-to-end verification against the published `@adasp/latency-test@1.2.0` package — the only remaining v1 item. (Phase 4 is complete: browser verification matrix done across all three modes; host-side histogram moved to the Phase 8 experimentation toolkit.)
- Phase 6: framework example end-to-end verification against the published `@adasp/latency-test@1.2.0` package — the only remaining v1 item. Verification host apps live in the dedicated repo https://github.com/idsinge/latency-test-examples (published-package-only; methodology in that repo's CLAUDE.md). (Phase 4 is complete: browser verification matrix done across all three modes; host-side histogram moved to the Phase 8 experimentation toolkit.)

**Planned configurable attributes (beyond `number-of-tests`, `mls-bits`, `max-lag-ms`):**

Expand Down
1 change: 1 addition & 0 deletions agents/KNOWN_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Each entry records the source, severity, current status, and what would be neede
**Source:** `agents/CLAUDE_REVIEW.md` Phase 6 gate · **Severity:** Low
**Detail:** The six framework example pages (`docs/examples/*.md`: vanilla-js, React, Vue, Svelte, Angular, Next.js) were updated based on the local source but have not been verified end-to-end against the actual installed npm package. (The seventh page, `host-gain.md`, is a pattern page outside this gate — it is exercised by the demo's Host Gain panel against the built bundle.) Draft notices were removed trusting the code to be correct — if an example has a subtle error it would only surface during a consumer's actual use.
**Fix:** For each framework: install `@adasp/latency-test` in a fresh project, follow the example page instructions exactly, confirm the component registers and emits events correctly. Only then is the example considered fully verified.
**Status (2026-06-12):** verification prepared, not yet started — execution model recorded; the dedicated examples repo https://github.com/idsinge/latency-test-examples is seeded (methodology in that repo's `CLAUDE.md`; execution model in `agents/SESSION_HANDOFF.md`). All matrix rows pending.

---

Expand Down
12 changes: 11 additions & 1 deletion agents/SESSION_HANDOFF.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ See `agents/KNOWN_ISSUES.md` for open findings from code reviews (Codex, DeepSee

## Current Repo State

- Stable base: `main` (branch protection: PR + "ci" status check required — work on a branch and open a PR). Current working branch: `docs/install-dedup-build-output` (PR #25 — docs cleanup, histogram move to Phase 8, and Codex consistency fixes; merge pending CI). `webcomponent` fully merged via PRs #14–24.
- Stable base: `main` (branch protection: PR + "ci" status check required — work on a branch and open a PR). All cleanup PRs merged: #25 (histogram→Phase 8 + consistency fixes), #26 (install.md demo instructions, stale-text cleanup, review-prompt.md deleted), #27 (AGENTS.md fixes stranded by a merge race). No active working branch — Phase 6 verification runs in the external examples repo (see "Phase 6 execution model" below). `webcomponent` fully merged via PRs #14–24.
- Phases 1–7 complete. **v1.2.0** is live on npm as `@adasp/latency-test` (released 2026-06-12).
- `dist/` remains gitignored — generated with `npm run build:component`.
- `demo/` validates the built IIFE bundle via `../dist/latency-test.legacy.iife.js`. Run with `npm run build:component:legacy && npm run demo`.
Expand Down Expand Up @@ -117,6 +117,16 @@ See `agents/KNOWN_ISSUES.md` for open findings from code reviews (Codex, DeepSee
### Phase 6 remainder
- [ ] Framework example end-to-end verification — before treating any framework example as verified, test it against the installed published package `@adasp/latency-test@1.2.0` (not local source). Scope: the six framework pages (vanilla-js, React, Vue, Svelte, Angular, Next.js). `host-gain.md` is out of scope — it is a pattern page exercised by the demo's Host Gain panel against the built bundle (decision 2026-06-12). All Draft labels are already removed; if examples are found wrong during verification, a patch is needed.

#### Phase 6 execution model (2026-06-12)

Verification happens in a dedicated external repo: **https://github.com/idsinge/latency-test-examples** (local: `~/Desktop/latency-test-examples`). Rationale: structurally guarantees published-package consumption (no `file:`/workspace links possible), keeps this research repo lean, isolates dependency noise. That repo's `CLAUDE.md` is the single source of truth for the verification methodology — do not duplicate its rules here. Key facts only:

- Two tiers: `examples/` = the six framework apps (this Phase 6 gate; exact pin `1.2.0`, apps mirror the docs pages literally, README matrix with per-check legend = the verification record incl. docs-commit SHA and environment); `demos/` = latency-compensation R&D (waveform-playlist React, `@dawcore/*`), **hard-quarantined until Tier 1 signoff**.
- Pass criteria were tightened through two Codex review rounds — five success-path events + no `latency-error`, deliberate negative-path test, registry-consumption proof, dev AND production build with clean console, CDN variant for vanilla-js, environment recorded.
- A separate Claude instance works there, bootstrapped by `agents/KICKOFF_PROMPT.md` in that repo. Status at handoff: seed files review-hardened (two Codex rounds) and committed (examples repo initial commit `0804b8f`); verification work itself not yet started — all matrix rows pending.
- Forced deviations from a docs page are findings → relayed back to THIS repo as docs patches (branch + PR, as usual).
- **Phase 6 signoff happens here** when the matrix is complete: run `npm run build:component:all`, `npm run docs:build`, `npm pack --dry-run`; close the KNOWN_ISSUES open item; update this file; link the verified examples repo from the docs.

### Independent
- [x] **CI Node version divergence** — Intentional and closed. `.nvmrc=22` (local dev), `ci.yml=20` (test/build job), `docs.yml=24` (Pages build/deploy workflow). All satisfy `engines: >=18`. See `agents/KNOWN_ISSUES.md`.

Expand Down