Release MLVScan.Core 1.8.2 - #50
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42b2737d8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bool hidesExecution = Contains(finding.Description, "CreateNoWindow=true") || | ||
| Contains(finding.Description, "WindowStyle=Hidden") || | ||
| Contains(finding.Description, "UseShellExecute=true"); |
There was a problem hiding this comment.
Require an actual hidden-window setting
UseShellExecute=true only selects the operating-system shell for process startup; it does not conceal the new process. For a method that downloads and transforms text before visibly launching PowerShell with dynamic arguments, this branch emits a “hidden shell” coordinator finding, and the matching predicate in ThreatFamilyCatalog.NewSamples.cs likewise accepts UseShellExecute=true, promoting the file to the blocking KnownThreat disposition. Require CreateNoWindow=true or WindowStyle=Hidden instead of treating UseShellExecute as hidden execution.
Useful? React with 👍 / 👎.
| var namespaceSource = calls.FirstOrDefault(call => IsNetworkTextRead(call.Called)); | ||
| var namespaceFinding = processFindings.FirstOrDefault(finding => | ||
| Contains(finding.Description, "CreateNoWindow=true") || | ||
| Contains(finding.Description, "WindowStyle=Hidden")); | ||
| if (structuralLauncher != null && | ||
| namespaceSource.Called != null && | ||
| namespaceFinding != null && | ||
| calls.Any(call => IsRemoteTextTransform(call.Called))) |
There was a problem hiding this comment.
Correlate fallback signals to the same async operation
In assemblies containing several classes under one namespace, this fallback can combine a fragmented hidden launcher from one method, a GetString call from another, a string transform from a third, and any hidden-process finding in the namespace. For example, an unrelated update checker and a local hidden launcher are consequently labeled as the remote-text malware family and blocked as KnownThreat. Restrict this fallback to the relevant state-machine/originating method relationship rather than testing independent namespace-wide signals.
Useful? React with 👍 / 👎.
| if (TryFindRemoteTextHiddenShellExecution( | ||
| calls, | ||
| scopedProcessFindings, | ||
| out var remoteTextCall, | ||
| out var shellFinding)) |
There was a problem hiding this comment.
Scan remote-text launchers in the global namespace
This new detector runs only inside the surrounding namespace-group loop, which filters out every top-level type whose Namespace is empty. A remote-text hidden-shell launcher declared in the global namespace therefore never reaches this call and receives no behavior-family match unless its exact hash is already cataloged, providing a straightforward detection bypass for new samples. Include global-namespace types in the grouping or run this analysis independently of that filter.
Useful? React with 👍 / 👎.
Closes the confirmed-malware detection gaps for encoded EVM/Java staging and fragmented hidden-shell execution, adds exact sample coverage for Meowtopia and SunriseFurrowCoach, and aligns the Core/WASM package versions at 1.8.2.
MLVScan.Coreand WASM package version1.8.2.