fix(auth): enforce trusted external identity attributes - #631
Closed
XiaoSeS wants to merge 1 commit into
Closed
Conversation
Signed-off-by: ylhu16 <ylhu16@iflytek.com>
|
ylhu16 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EMAIL_DOMAINaccess/user/emailsPENDING,DISABLED,MERGED, and system accounts before profile updates or role loadingWhy
Closes #629. This is PR 0A from #628 and establishes the immediate safety invariants before the unified identity core is introduced.
How
The existing OAuth claims contract remains compatible. The binding service now gates trusted profile updates on
emailVerifiedand applies an account-state guard before mutation. No schema or public API changes are introduced.Testing
Java 21 container:
skillhub-authreactor run: 130/131 tests passedSecurityContextHolderleak:OAuth2LoginHandlersTestleaves a principal thatApiTokenAuthenticationFilterTest.shouldIgnoreNonBearerAuthorizationHeaderobserves; the same failure was reproduced on an untouchedorigin/mainApiTokenAuthenticationFilterTestpasses when run independentlygit diff origin/main...HEAD --checkTest-environment deployment is intentionally pending. This PR remains draft until it is integrated into
big-mainand the relevant login regressions are validated.Impact