fix(auth): provision global membership on user approval - #633
Closed
XiaoSeS wants to merge 2 commits into
Closed
Conversation
added 2 commits
July 30, 2026 15:03
Closes #632 Signed-off-by: ylhu16 <ylhu16@iflytek.com>
Signed-off-by: ylhu16 <ylhu16@iflytek.com>
|
ylhu16 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
ylhu16 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@globalMEMBERmembership whenever an administrator activates a pending or disabled accountPENDING_APPROVALMERGEDand system accountsWhy
A pending account could be approved without receiving the namespace membership required by normal authenticated workflows. In addition, the OAuth flow reevaluated
PENDING_APPROVALbefore resolving an existing binding, which could send an already approved user back to the pending page.Closes #632
Parent: #628
How
AdminUserAppServicenow delegates membership provisioning to the existing idempotentGlobalNamespaceMembershipServiceinside the status-update transaction. The OAuth flow usesPENDINGonly as the initial status when resolving aPENDING_APPROVALdecision, so the stored account status remains authoritative after an administrator acts.Testing
AdminUserAppServiceTestAdminUserApprovalIntegrationTestUserManagementControllerTestGlobalNamespaceMembershipServiceTestOAuthLoginFlowServiceTestIdentityBindingServiceTestbash -n scripts/smoke-test.shskillhub-server:identity-p0b)ApiTokenAuthenticationFilterTest.shouldIgnoreNonBearerAuthorizationHeaderglobalSecurityContextHolderleak fromorigin/main; the failing test passes alone and is unrelated to this diff5432; the new HTTP smoke path will be run from thebig-maintest deploymentImpact
big-mainand validated in the test environment before it is considered formain