fix(alerts): cap predictive AGL look-ahead at 120s#49
Merged
Conversation
The inbound AGL gate (max_alt_agl_ft + max_closest_approach_nm) projected the track's altitude over the *full* ETA to closest approach. That extrapolation is a straight line — current AGL + vertical_rate * time — so over a multi-minute ETA a routine descent rate drove the projected altitude far below the threshold while the aircraft was still high and tens of nm out. A descending Global Express at ~3000 ft, 20+ nm away, tripped a 1000 ft AGL drone-conflict rule ~6 min early. Cap the look-ahead at 120s: keep the "fire before it dips into drone airspace" early-warning, but only when the track will actually be low soon (~6 nm), not on the first sign of any descent far out. Also surface vertical_rate_fpm in the alert `info` attributes so the per-rule binary_sensor shows the rate that drove a predictive firing — it was previously invisible, leaving no way to see why the gate tripped. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inbound AGL gate (max_alt_agl_ft + max_closest_approach_nm) projected the track's altitude over the full ETA to closest approach. That extrapolation is a straight line — current AGL + vertical_rate * time — so over a multi-minute ETA a routine descent rate drove the projected altitude far below the threshold while the aircraft was still high and tens of nm out. A descending Global Express at ~3000 ft, 20+ nm away, tripped a 1000 ft AGL drone-conflict rule ~6 min early.
Cap the look-ahead at 120s: keep the "fire before it dips into drone airspace" early-warning, but only when the track will actually be low soon (~6 nm), not on the first sign of any descent far out.
Also surface vertical_rate_fpm in the alert
infoattributes so the per-rule binary_sensor shows the rate that drove a predictive firing — it was previously invisible, leaving no way to see why the gate tripped.