Draft
Conversation
Author
|
The code at this point is more "easy to read" than efficient, it has way too many for loops. However, I don't think speed will ever be a problem in rebinning / covariance estimation, so I wouldn't worry about it. If it ever was, we could just rewrite the loops to make it a lot faster (but harder to read). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet a proper pull request, but we can use the tools to review the code.
Better to discuss it "in person" (Zoom), but I wanted to have a set of "PX objects" that can eventually be used in the likelihood code, but that they can also be used to do the post-processing of the raw measurements. You can do things like:
I add a few notebooks explaining how these work. I guess the one closer to the final use would be
rebinned_covariance, but the others might help you understand the intermediate steps.I've been sloppy with the window matrix, but I believe it should be easy to finish it relatively fast. However, it would be very useful to know exactly how the matrix would be used in the likelihood code.