Add time metric and car and pedestrian profiles to DistanceTool - #207
Merged
Merged
Conversation
LionelZoubritzky-IGN
force-pushed
the
138/distance-tool_navigation_modes
branch
from
October 2, 2026 09:15
c043953 to
3aead89
Compare
LionelZoubritzky-IGN
changed the base branch from
138/distance-tool
to
138/distance-tool-experiment
October 2, 2026 09:15
LionelZoubritzky-IGN
force-pushed
the
138/distance-tool_navigation_modes
branch
from
October 2, 2026 09:17
3aead89 to
fb4d3f1
Compare
Base automatically changed from
138/distance-tool-experiment
to
138/distance-tool
October 2, 2026 09:33
LionelZoubritzky-IGN
added this to the
v0.11.x - Lightweight Geometries and Schema Integration milestone
LionelZoubritzky-IGN
force-pushed
the
138/distance-tool_navigation_modes
branch
2 times, most recently
from
October 2, 2026 12:05
e142cbf to
5c5a7da
Compare
LionelZoubritzky-IGN
force-pushed
the
138/distance-tool_navigation_modes
branch
from
October 2, 2026 12:39
5c5a7da to
26ea39c
Compare
* fix(itinerary): route with Valhalla, like the travel time isochrones The distance tool used bdtopo-osrm while travel_time_filter isochrones use bdtopo-valhalla, so the two could disagree by up to 12% on walking times. Reuse TRAVEL_TIME_RESOURCE for the itinerary. * fix(distance): restore the ellipsoidal precision lost in the rebase The rebase brought back "plus précise et coûteuse, précision à 1mm" instead of the 0.5 cm wording merged in #183, and the new ", " join produced "suivi :, `spherical`". Join the profile lines as before. * fix(distance): keep a tenth of a minute in the travel time Rounding to the whole minute turned a 40-second walk into 1 or even 0 minutes. * docs(distance): say which profiles return a travel time `profile` always has a value (`spherical` by default), so "lorsqu'un profil est renseigné" was always true. * fix(distance): round the itinerary distance to the centimeter The spherical and ellipsoidal profiles already round to the centimeter; the itinerary passed the service value through as is.
esgn
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
timemetric andcarandpedestrianprofiles toDistanceToolMotivation
This provides the LLM with the capability to evaluate the time it takes to go from one point to another, either by foot or by car. The itinerary itself is not provided (dedicated tool in #191).
Implementation
Use Gpf navigation API. It needs to return a geometry (which is not returned in the current tool), so I opted for "polyline" because it is the most lightweight option.
Testing
npm run build && npm run verify: 599+35 tests all green.Manual testing on MCP inspector.
Checklist