Repository navigation
feat: limit too big filters - #216
Open
LionelZoubritzky-IGN wants to merge 2 commits into
Open
LionelZoubritzky-IGN wants to merge 2 commits into
LionelZoubritzky-IGN wants to merge 2 commits into
Conversation
LionelZoubritzky-IGN
force-pushed
the
151/reject-big-filters
branch
from
October 13, 2026 08:55
6604027 to
3f6ad42
Compare
LionelZoubritzky-IGN
marked this pull request as ready for review
October 13, 2026 09:00
LionelZoubritzky-IGN
force-pushed
the
151/reject-big-filters
branch
from
October 13, 2026 14:25
3f6ad42 to
8778c02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reject any query that requires a too-big CQL filter ("too big" is at 2 MiB, checked experimentally).
Related issues (if applicable)
Close #151, close #215.
Motivation
Too big filters lead to timeout or to silently wrong answers (see #215).
Implementation
Check the size of the
intersect_feature_filterand reject it if too large with a clear error message. Also guard against too large CQL filters in general (which could result from a too-largewhereclause as well).The filter never silently switches to the
-CARTO-PEversion because the id can change:departement.72does not mean the same thing inADMINEXPRESS-COG.LATESTand inADMINEXPRESS-COG-CARTO-PE.LATEST. However, the error message gives a hint to the LLM that it should use the-CARTO-PEversion.Testing
npm run build && npm run verify: 611+4+35 tests green and "how many buildings in Vendée" correctly returns around 840000.Checklist