Skip to content

Translate WFS date and date-time types for OGC API Feature schema - #74

Merged
mborne merged 3 commits into
mainfrom
37-date-and-date-time
Jul 28, 2026
Merged

mborne merged 3 commits into
mainfrom
37-date-and-date-time

Conversation

@mborne

@mborne mborne commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Schema improvements for date fields:

  • Keep track of "format": "date-time" and "format": "date" from WFS DescribeFeatureType
  • Update catalog

"format": "date-time" and "format": "date" is added to date_creation, date_modification, date_d_apparition, and date_de_confirmation fields in various BDTOPO_V3 schema files, improving the precision and validation of these fields.

(refs #37)

Copilot AI review requested due to automatic review settings July 28, 2026 10:16
@mborne

mborne commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@esgn / @LionelZoubritzky-IGN I suggest to move this part of #37 in a v0.2.1 of gpf-schema-store in order to unlock ignfab/geocontext#182

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request extends the pivot property-type system to include date and date-time (instead of treating them as plain string), and updates both WFS snapshots and generated OGC API Features JSON Schemas to consistently represent dates/timestamps using JSON Schema format (date / date-time).

Changes:

  • Added date / date-time as first-class CollectionPropertyType values and mapped WFS localType values accordingly.
  • Updated the OGC API Features schema writer to emit { "type": "string", "format": "date" | "date-time" } for these new pivot types.
  • Updated many WFS snapshot definitions and their corresponding catalog schemas to reflect date/date-time typing (notably gpu_timestamp and multiple BDTOPO date fields).

Reviewed changes

Copilot reviewed 185 out of 186 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/source/wfs/mapping.ts Map WFS date / date-time localType to pivot date / date-time.
src/pivot/types.ts Add date and date-time to supported scalar property types.
src/ogc-api-feature/writer.ts Render date / date-time pivot types as JSON Schema string with format.
package.json Bump package version to 0.2.1.
package-lock.json Sync lockfile version fields to 0.2.1.
data/wfs/wfs_sup/servitude.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/servitude_acte_sup.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/gestionnaire_sup.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/generateur_sup_s.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/generateur_sup_p.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/generateur_sup_l.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/assiette_sup_s.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/assiette_sup_p.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/assiette_sup_l.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_sup/acte_sup.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_scot/scot.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_scot/perimetre_scot.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_scot/doc_urba.json Change gpu_timestamp type to date-time.
data/wfs/wfs_scot/doc_urba_com.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/zone_urba.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/secteur_cc.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/prescription_surf.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/prescription_pct.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/prescription_lin.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/mec.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/info_surf.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/info_pct.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/info_lin.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/habillage_txt.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/habillage_surf.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/habillage_pct.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/habillage_lin.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/document.json Change gpu_timestamp type from string to date-time.
data/wfs/wfs_du/doc_urba.json Change gpu_timestamp type to date-time; add nomrapp/urlrapp fields.
data/wfs/wfs_du/doc_urba_com.json Change gpu_timestamp type from string to date-time.
data/wfs/BDTOPO_V3/zone_de_vegetation.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/zone_d_habitation.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/zone_d_estran.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/zone_d_activite_ou_d_interet.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/voie_nommee.json Use date-time type for creation/modification fields.
data/wfs/BDTOPO_V3/voie_ferree_nommee.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/troncon_hydrographique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/troncon_de_voie_ferree.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/troncon_de_route.json Use date / date-time types for date-related fields (incl. date_de_mise_en_service).
data/wfs/BDTOPO_V3/transport_par_cable.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/toponymie.json Use date type for date_du_toponyme.
data/wfs/BDTOPO_V3/terrain_de_sport.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/surface_hydrographique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/section_de_points_de_repere.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/route_numerotee_ou_nommee.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/reservoir.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/region.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/pylone.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/poste_de_transformation.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/point_du_reseau.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/point_de_repere.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/point_d_acces.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/plan_d_eau.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/piste_d_aerodrome.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/parc_ou_reserve.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/non_communication.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/noeud_hydrographique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/limite_terre_mer.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/ligne_orographique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/ligne_electrique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/lieu_dit_non_habite.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/itineraire_autre.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/haie.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/foret_publique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/equipement_de_transport.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/epci.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/detail_orographique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/detail_hydrographique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/departement.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/cours_d_eau.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/construction_surfacique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/construction_ponctuelle.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/construction_lineaire.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/condominium.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/commune.json Use date / date-time types for date-related fields (incl. date_du_recensement).
data/wfs/BDTOPO_V3/commune_associee_ou_deleguee.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/collectivite_territoriale.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/cimetiere.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/canalisation.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/batiment.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/bassin_versant_topographique.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/arrondissement.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/arrondissement_municipal.json Use date / date-time types for date-related fields.
data/wfs/BDTOPO_V3/aerodrome.json Use date / date-time types for date-related fields.
data/wfs/ADMINEXPRESS-COG.LATEST/commune.json Change date_du_recensement type from string to date.
data/wfs/ADMINEXPRESS-COG.2026/commune.json Change date_du_recensement type from string to date.
data/wfs/ADMINEXPRESS-COG.2025/commune.json Change date_du_recensement type from string to date.
data/wfs/ADMINEXPRESS-COG-CARTO-PE.LATEST/commune.json Change date_du_recensement type from string to date.
data/wfs/ADMINEXPRESS-COG-CARTO-PE.2026/commune.json Change date_du_recensement type from string to date.
data/wfs/ADMINEXPRESS-COG-CARTO-PE.2025/commune.json Change date_du_recensement type from string to date.
data/namespaces.csv Update namespace entries/metadata (add/remove/adjust rows).
data/catalog/wfs_sup/servitude.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/servitude_acte_sup.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/gestionnaire_sup.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/generateur_sup_s.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/generateur_sup_p.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/generateur_sup_l.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/assiette_sup_s.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/assiette_sup_p.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/assiette_sup_l.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_sup/acte_sup.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_scot/scot.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_scot/perimetre_scot.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_scot/doc_urba.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_scot/doc_urba_com.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/zone_urba.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/secteur_cc.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/prescription_surf.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/prescription_pct.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/prescription_lin.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/mec.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/info_surf.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/info_pct.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/info_lin.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/habillage_txt.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/habillage_surf.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/habillage_pct.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/habillage_lin.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/document.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/wfs_du/doc_urba.json Add JSON Schema format: date-time for gpu_timestamp; add nomrapp/urlrapp properties.
data/catalog/wfs_du/doc_urba_com.json Add JSON Schema format: date-time for gpu_timestamp.
data/catalog/BDTOPO_V3/zone_de_vegetation.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/zone_d_habitation.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/zone_d_estran.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/zone_d_activite_ou_d_interet.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/voie_nommee.json Add JSON Schema format: date-time for creation/modification fields.
data/catalog/BDTOPO_V3/voie_ferree_nommee.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/troncon_hydrographique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/troncon_de_voie_ferree.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/troncon_de_route.json Add JSON Schema format: date / date-time for date-related fields (incl. date_de_mise_en_service).
data/catalog/BDTOPO_V3/transport_par_cable.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/toponymie.json Add JSON Schema format: date for date_du_toponyme.
data/catalog/BDTOPO_V3/terrain_de_sport.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/surface_hydrographique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/section_de_points_de_repere.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/route_numerotee_ou_nommee.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/reservoir.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/region.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/pylone.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/poste_de_transformation.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/point_du_reseau.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/point_de_repere.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/point_d_acces.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/plan_d_eau.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/piste_d_aerodrome.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/parc_ou_reserve.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/non_communication.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/noeud_hydrographique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/limite_terre_mer.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/ligne_orographique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/ligne_electrique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/lieu_dit_non_habite.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/itineraire_autre.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/haie.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/foret_publique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/equipement_de_transport.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/epci.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/detail_orographique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/detail_hydrographique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/departement.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/cours_d_eau.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/construction_surfacique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/construction_ponctuelle.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/construction_lineaire.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/condominium.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/commune.json Add JSON Schema format: date / date-time for date-related fields (incl. date_du_recensement).
data/catalog/BDTOPO_V3/commune_associee_ou_deleguee.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/collectivite_territoriale.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/cimetiere.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/canalisation.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/batiment.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/bassin_versant_topographique.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/arrondissement.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/arrondissement_municipal.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/BDTOPO_V3/aerodrome.json Add JSON Schema format: date / date-time for date-related fields.
data/catalog/ADMINEXPRESS-COG.LATEST/commune.json Add JSON Schema format: date for date_du_recensement.
data/catalog/ADMINEXPRESS-COG.2026/commune.json Add JSON Schema format: date for date_du_recensement.
data/catalog/ADMINEXPRESS-COG.2025/commune.json Add JSON Schema format: date for date_du_recensement.
data/catalog/ADMINEXPRESS-COG-CARTO-PE.LATEST/commune.json Add JSON Schema format: date for date_du_recensement.
data/catalog/ADMINEXPRESS-COG-CARTO-PE.2026/commune.json Add JSON Schema format: date for date_du_recensement.
data/catalog/ADMINEXPRESS-COG-CARTO-PE.2025/commune.json Add JSON Schema format: date for date_du_recensement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LionelZoubritzky-IGN LionelZoubritzky-IGN left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR!
I think you want to change the fallback to the standard geometry-any though.

Comment thread src/ogc-api-feature/writer.ts Outdated
Co-authored-by: LionelZoubritzky-IGN <lionel.zoubritzky@ign.fr>
Copilot AI review requested due to automatic review settings July 28, 2026 11:25
@LionelZoubritzky-IGN

Copy link
Copy Markdown
Contributor

You should also update the affected catalog files, like

"format": "geometry-geometry",

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 185 out of 186 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

src/ogc-api-feature/writer.ts:77

  • CollectionPropertyType value 'geometry' is currently rendered with format: 'geometry-any', but existing generated catalog schemas use format: 'geometry-geometry' for generic geometries (e.g. data/catalog/wfs_du/doc_urba.json:72-75). This would change the public schema output for all WFS layers that use type: 'geometry' and likely break consumers expecting the established geometry-<type> convention.
    src/ogc-api-feature/writer.ts:63
  • New date/date-time rendering logic is introduced here, but there are no unit tests asserting the JSON Schema output includes the expected { type: 'string', format: 'date' | 'date-time' }. Since test/unit/ogc-api-feature/writer.test.ts already covers other scalar/geometry cases, please add a focused test case for type: 'date' and type: 'date-time' to prevent regressions.
    data/wfs/wfs_du/doc_urba.json:100
  • This PR is described as a date/date-time type/format translation, but this hunk also adds new properties (nomrapp, urlrapp) to the wfs_du:doc_urba schema. If these fields are intentionally being introduced, the PR description should be updated (or the change split) so reviewers/users can track the non-type-related schema expansion.

Copilot AI review requested due to automatic review settings July 28, 2026 11:32
@mborne

mborne commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@LionelZoubritzky-IGN I have updated the catalog and created an issue for the concerned types ( #75 ).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 186 out of 187 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (5)

src/ogc-api-feature/writer.ts:63

  • The new date/date-time translation logic isn’t covered by the existing OGC API Feature writer unit tests. Add test cases to assert that CollectionPropertyType 'date' and 'date-time' render as JSON Schema {"type":"string","format":"date"} / {"type":"string","format":"date-time"}.
    src/source/wfs/mapping.ts:29
  • Support for WFS localType 'date' and 'date-time' was added, but the WFS client/mapping tests don’t validate these new mappings. Add unit coverage to ensure these localType values are accepted and correctly mapped to the new pivot property types.
    src/pivot/types.ts:17
  • New scalar property types ('date', 'date-time') were added, but the existing pivot helper tests don’t assert they are recognized as valid property types. Add assertions for these values to prevent regressions.
    data/namespaces.csv:197
  • This PR updates multiple entries in data/namespaces.csv (adds/removes/renames datasets) in addition to the date/date-time schema work. If these namespace rule changes are intentional, please document them in the PR description or split them into a separate PR to keep the change set focused and easier to audit.
    data/wfs/wfs_du/doc_urba.json:104
  • In addition to changing gpu_timestamp to date-time, this update adds the 'nomrapp' and 'urlrapp' properties to the wfs_du:doc_urba schema. If this is intended, consider mentioning it in the PR description (or moving it to a separate PR) so reviewers understand it’s part of the expected schema refresh.

@LionelZoubritzky-IGN

Copy link
Copy Markdown
Contributor

Last question I'm not sure about: wfs_du/wfs_scot/wfs_sup have fields like datedecis, datepub, datesrcass, datemaj, etc. They're still just type: "string". Should these get format: "date" or format: "date-time"?

@mborne
mborne merged commit 9f19bae into main Jul 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants