Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
May solve #191 (to be tested).
Changes
Three different ones:
FloatArrayGeographicDataMatrix2d.getFloatreturning unwanted value ifxout of bounds;Feature description
TODO
Technical changes
TODO
Only half way is done (maybe more).
Deal with raster data
When we use raster data we have to do an extra computation that was forgotten.
We used to :
That last step was wrong. If cell size is large, that would be very inaccurate.
The real cellsize and offset should be computed from actual raster data sample position (this does not depend on envelope).
So the new process should be:
TODOs
Self-checks
Relevant documentation inside the/docsfolder has been updatedexamples/work the same (or have been adapted if subject to changes in this PR)The texts have been proofread (documentation, error messages, logs, comments...)