Refactor Modo init: deprecate legacy API, unify caching, added unit tests#76
Open
ikarenkov wants to merge 4 commits intoreleases/0.11.0from
Open
Refactor Modo init: deprecate legacy API, unify caching, added unit tests#76ikarenkov wants to merge 4 commits intoreleases/0.11.0from
ikarenkov wants to merge 4 commits intoreleases/0.11.0from
Conversation
Owner
ikarenkov
commented
Apr 20, 2026
ikarenkov
commented
- Deprecate getOrCreateRootScreen/save/onRootScreenFinished (use rememberRootScreen, removed in 1.0)
- Unify all init paths through rootScreens.getOrPut for consistent in-memory caching
- Rename restoreScreenCounter → restoreScreenCounterIfNeeded; extract isFragmentClosing
- Add ModoLegacyIntegrationFragment + button in MainScreen for legacy fragment demo
- Add ModoRootScreenCacheTest covering all 3 init scenarios (first init, backstack, bundle restore)
- Add MockK 1.13.12 as test dependency
… add unit tests - Deprecate getOrCreateRootScreen/save/onRootScreenFinished (use rememberRootScreen, removed in 1.0) - Unify all init paths through rootScreens.getOrPut for consistent in-memory caching - Rename restoreScreenCounter → restoreScreenCounterIfNeeded; extract isFragmentClosing - Add ModoLegacyIntegrationFragment + button in MainScreen for legacy fragment demo - Add ModoRootScreenCacheTest covering all 3 init scenarios (first init, backstack, bundle restore) - Add MockK 1.13.12 as test dependency
# Conflicts: # gradle/libs.versions.toml # modo-compose/build.gradle.kts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| detektComposeVersion = "0.3.20" | ||
| detektVersion = "1.23.6" | ||
| junit = "4.13.2" | ||
| mockk = "1.13.12" |
ikarenkov
force-pushed
the
refactor-remember-counter-and-root
branch
from
f8cd13e to
42c5aaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.