Skip to content

Fix all formatting-related pylint complaints under fre/, raise fail-under to 8.89#5

Closed
Copilot wants to merge 7 commits into
mainfrom
copilot/fix-pylint-formatting-issues
Closed

Fix all formatting-related pylint complaints under fre/, raise fail-under to 8.89#5
Copilot wants to merge 7 commits into
mainfrom
copilot/fix-pylint-formatting-issues

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 11, 2026

Describe your changes

Resolves all formatting-related pylint complaints across fre/431 issues fixed, score improved from 8.02 → 8.89. No logic or behavior changes.

Issue Count
bad-indentation (2-space → 4-space) 269
line-too-long (>120 chars) 67
wrong-import-order 47
trailing-whitespace 19
wrong-import-position 19
f-string-without-interpolation 10
multiple-statements 9
superfluous-parens 8
unnecessary-pass 7
trailing-newlines 2
  • pylintrc: fail-under raised from 8.30 to 8.89

52 files touched. Remaining pylint issues are non-formatting (naming, complexity, unused imports, etc.) — intentionally left alone per scope.

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Break long lines using parentheses, backslashes, and string
concatenation to stay within the 120-character pylint limit.
No logic or behavior changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 75.72254% with 42 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fre/pp/split_netcdf_script.py 69.91% 37 Missing ⚠️
fre/app/regrid_xy/regrid_xy.py 0.00% 1 Missing ⚠️
fre/app/remap_pp_components/remap_pp_components.py 50.00% 1 Missing ⚠️
fre/pp/frepp.py 80.00% 1 Missing ⚠️
fre/pp/install_script.py 75.00% 1 Missing ⚠️
fre/pp/ppval_script.py 75.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   84.10%   84.22%   +0.12%     
==========================================
  Files          70       70              
  Lines        4780     4773       -7     
==========================================
  Hits         4020     4020              
+ Misses        760      753       -7     
Flag Coverage Δ
unittests 84.22% <75.72%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/__init__.py 100.00% <100.00%> (ø)
fre/analysis/freanalysis.py 74.28% <100.00%> (ø)
fre/app/generate_time_averages/combine.py 92.72% <ø> (ø)
...p/generate_time_averages/generate_time_averages.py 91.80% <ø> (ø)
fre/app/helpers.py 97.29% <100.00%> (ø)
fre/catalog/frecatalog.py 94.44% <ø> (ø)
fre/cmor/cmor_config.py 97.53% <100.00%> (ø)
fre/cmor/frecmor.py 100.00% <100.00%> (ø)
fre/make/create_compile_script.py 98.03% <100.00%> (ø)
fre/make/create_docker_script.py 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5641dc7...d5b3338. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI and others added 5 commits March 11, 2026 15:28
Break long lines in docstrings, comments, f-strings, function calls,
and click help strings across 8 files in fre/pp/. No logic changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Break long lines using Python line continuation rules (parentheses,
string concatenation, line wrapping at commas) without changing any
logic or behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…essary-pass, f-string-without-interpolation

- Split multiple statements on single lines onto separate lines (generate_files.py)
- Remove unnecessary parentheses after not/return/= keywords (split_netcdf_script.py, test_split_netcdf.py, test_histval_script.py)
- Remove unnecessary pass in abstract methods with docstrings (abstract_classes.py)
- Remove f-prefix from f-strings without interpolation (generate_files.py, test_regrid_xy.py, split_netcdf_script.py, cmor_config.py, test_cmor_find_subtool.py)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…space, trailing-newlines, line-too-long, wrong-import-order, wrong-import-position, multiple-statements, superfluous-parens, unnecessary-pass, f-string-without-interpolation

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…tting fixes

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix formatting-related pylint complaints in fre/ Fix all formatting-related pylint complaints under fre/, raise fail-under to 8.89 Mar 11, 2026
@ilaflott ilaflott closed this Mar 11, 2026
ilaflott pushed a commit that referenced this pull request Mar 18, 2026
Added a note regarding test completion dependency on issue #5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants