Skip to content
This repository was archived by the owner on Apr 20, 2020. It is now read-only.

[OpLabelVolume] reduce code duplication#135

Merged
burgerdev merged 3 commits intoilastik:masterfrom
burgerdev:OpLabelVolume-remove-code-duplication
May 8, 2014
Merged

[OpLabelVolume] reduce code duplication#135
burgerdev merged 3 commits intoilastik:masterfrom
burgerdev:OpLabelVolume-remove-code-duplication

Conversation

@burgerdev
Copy link
Copy Markdown
Member

I read some lines of code in OpCompressedCache recently, and realized that I had rewritten some multithreading and block handling logic in OpLabelVolume. Major changes are:

  • OpLabelVolume.Output operates on a WYRIWYG basis (what you request ...) with no cache involved
  • blocked labeling was disabled because
    1. the PR Connected Components python interface thorbenk/blockedarray#4 is not merged yet
    2. the blocked labeling operator has to be rewritten to satisfy new requirements by OpLabelingABC
    3. chances are that we have a lazy labeling operator in the near future

ilastik is not affected, because

  • OpLabelVolume is used only in thresholding
  • thresholding is using only OpLabelVolume.CachedOutput
  • OpLabelVolume.CachedOutput's API did not change

All lazyflow tests (except some dvid test) are passing on my machine.

burgerdev added a commit that referenced this pull request May 8, 2014
…ication

[OpLabelVolume] reduce code duplication
@burgerdev burgerdev merged commit f4879d8 into ilastik:master May 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant