Skip to content

Size limit on implementation section #5

Description

@MarkUK

When the section of a binding gets to a certain point (about 4200 characters on my system), the code stops working. It looks like there is a buffer whose maximum size is being exceeded, because the sort of errors that appear often involve missing closing tags.

The easiest way to reproduce this is to add a huge comment section to an existing method. However this problem is not limited to comments - it occurs if you add sufficient amounts of code or additional methods and properties.

Because this limit appears to affect the whole section, it can't easily be worked around by refactoring code into smaller functions or methods. 4200 characters is enough for simple bindings, but for complex creations it's far too low.

Steps to reproduce:

  1. Edit "implementation.xml" from the manual tests
  2. In the method block, add a suitably large comment (about 4100 characters are needed on my machine)
  3. Load the test into Firefox, ensuring that it's an uncached version that's loaded
  4. You should see an error in Firebug about an unterminated comment, missing closing brace or similar

I've been able to reproduce this issue on Firefox 3.6.x and Firefox 8.0. I haven't tested it on any other browsers at this time.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions