Skip to content

New Curriculum Report - Tagged Terms (Grouped)#9289

Open
michaelchadwick wants to merge 12 commits intoilios:masterfrom
michaelchadwick:frontend-6125-tagged-terms-rolled-up-report
Open

New Curriculum Report - Tagged Terms (Grouped)#9289
michaelchadwick wants to merge 12 commits intoilios:masterfrom
michaelchadwick:frontend-6125-tagged-terms-rolled-up-report

Conversation

@michaelchadwick
Copy link
Copy Markdown
Contributor

@michaelchadwick michaelchadwick commented Apr 15, 2026

Fixes ilios/ilios#6125

This creates a new variant of the Tagged Terms curriculum report. It also adds in a new toggle that only shows up when the Tagged Terms report is chosen. It defaults to Listed (one term per row, the current way of downloading the CSV data), but Grouped (multiple terms per row) is also available now.

Need to create tooltips, write tests for it, and probably workshop the toggle/config a bit.

Screenshot 2026-04-15 at 3 52 23 PM

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 15, 2026

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 3e292b1
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/69fb6cefe429210008a44324
😎 Deploy Preview https://deploy-preview-9289--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

❌ Visual Diff Report — FAILED

884 images compared: 226 different · 658 identical

Details

Differences (226)

File Diff % Notes
desktop-Acceptance _ course visualizations - vocabulary _ it renders _ .png 0.04%
desktop-Acceptance _ Instructor Groups _ filters options _ .png 0.06%
desktop-Acceptance _ Learner Group _ generate new subgroups _ toggleNewLearnerGroupForm.png 0.31%
desktop-Acceptance _ Program Year - Cohort members _ cohort members are expanded if URL contains corresponding parameter _ .png 0.34%
desktop-Acceptance _ Program Year - Cohort members _ expand and collapse cohort members _ .png 0.35%
desktop-Acceptance _ Program Year - Course associations _ course associations are expanded if URL contains corresponding parameter _ .png 0.35%
desktop-Acceptance _ Program Year - Course associations _ expand and collapse course associations _ .png 0.36%
desktop-Acceptance _ Program Year - Leadership _ collapsed leadership _ .png 0.07%
desktop-Acceptance _ Program Year - Leadership _ list leadership _ .png 0.06%
desktop-Acceptance _ Program Year - Objective Vocabulary Terms _ manage and save terms _ .png 0.06%
desktop-Acceptance _ Program Year - Objectives _ list editable _ .png 0.05%
desktop-Acceptance _ Program Year - Objectives _ list not editable _ .png 0.05%
desktop-Acceptance _ Program Year - Terms _ list terms _ .png 0.06%
desktop-Acceptance _ Program Year - Terms _ manage terms _ .png 0.05%
desktop-Acceptance _ Session - Objective List _ list objectives _ .png 0.03%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ cancel changes _ default background color.png 0.03%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ cancel changes _ managed background color.png 0.04%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ manage terms _ default background color.png 0.03%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ manage terms _ managed background color.png 0.04%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ save terms _ default background color.png 0.03%
desktop-Acceptance _ Session - Objective Mesh Descriptors _ save terms _ managed background color.png 0.04%
desktop-Acceptance _ Session - Objective Parents _ cancel changes _ default background color.png 0.04%
desktop-Acceptance _ Session - Objective Parents _ cancel changes _ managed background color.png 0.03%
desktop-Acceptance _ Session - Objective Parents _ deselect all parents for session objective _ default background color.png 0.04%
desktop-Acceptance _ Session - Objective Parents _ deselect all parents for session objective _ managed background color.png 0.03%
… and 201 more

Download the results.

@dartajax
Copy link
Copy Markdown
Member

I wanted to see the details on that because it is simply rolled up counts at the output level - rcvd this beaut ...

image

@michaelchadwick michaelchadwick force-pushed the frontend-6125-tagged-terms-rolled-up-report branch from 54f6c44 to b2edac6 Compare April 23, 2026 23:14
@michaelchadwick
Copy link
Copy Markdown
Contributor Author

@dartajax Thanks for pointing out that bug. I had forgotten a change in variable structure I did, and the download part was forgotten. Should be fixed now.

Copy link
Copy Markdown
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I eyeballed some of the downloaded records and it looks pretty good to me however I might want to do some more review if this is still available for additional review on Monday.

@michaelchadwick
Copy link
Copy Markdown
Contributor Author

NTS: Move toggle to download page, since that's where the actual change is applied to. Change the header title to reflect which choice is made.

@michaelchadwick michaelchadwick force-pushed the frontend-6125-tagged-terms-rolled-up-report branch from af12557 to cd14a93 Compare May 5, 2026 00:27
@michaelchadwick michaelchadwick marked this pull request as ready for review May 5, 2026 00:27
@michaelchadwick michaelchadwick marked this pull request as draft May 5, 2026 00:27
@michaelchadwick
Copy link
Copy Markdown
Contributor Author

Moved choice to report download page (as that's where the decision actually matters), and subbed out a toggle for a new component: DownloadDropdown. This lets a button create a menu (a la the LocaleChooser and UserMenu buttons in the header), and each menu button can have a different link and text and they both share the same action (in this case, downloading a file created-on-the-fly). The menu options also have a tooltip to explain the difference between them.

Screenshot 2026-05-04 at 5 27 49 PM

@michaelchadwick
Copy link
Copy Markdown
Contributor Author

michaelchadwick commented May 5, 2026

NTS: DownloadDropdown is the way.

Fixes to implement: actually make the different options create the proper files, add chevron toggle icon, change tooltip to use IliosTooltip, fix keyboard nav, fix mobile UI.

@michaelchadwick michaelchadwick marked this pull request as ready for review May 6, 2026 16:31
Copy link
Copy Markdown
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code reviewed, LGTM.

@stopfstedt stopfstedt removed the request for review from jrjohnson May 6, 2026 17:01
@dartajax
Copy link
Copy Markdown
Member

dartajax commented May 6, 2026

I will test this further but I'd like to know if these reports are coded to return all sessions in the output even if the course has no tagged terms AND the session has no tagged terms - will test on my own but wanted to throw that out there for thought. I think it should return all sessions even if both fields are empty (course terms, session terms) - just so folks no nothing has been tagged - my $.02 - if that's already the case, then fantastic but like I said, I will test and find out shortly.

@michaelchadwick
Copy link
Copy Markdown
Contributor Author

@dartajax Neither grouped nor listed will show rows pertaining to courses or sessions with no terms (e.g. create a brand new course and do this report; the downloads will still work but it will be an empty file). Please do a review and suggest that change and i'll come back and fix it

Copy link
Copy Markdown
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose returning all sessions in the report output even if NEITHER the course NOR the sessions have any associated tagged terms.

People could use this report to determine where maybe some tagging has been missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Curriculum Report - Terms Tagged - Rolled Up

3 participants