New Curriculum Report - Tagged Terms (Grouped)#9289
New Curriculum Report - Tagged Terms (Grouped)#9289michaelchadwick wants to merge 12 commits intoilios:masterfrom
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Visual Diff Report — FAILED884 images compared: 226 different · 658 identical DetailsDifferences (226)
Download the results. |
54f6c44 to
b2edac6
Compare
|
@dartajax Thanks for pointing out that bug. I had forgotten a change in variable structure I did, and the download part was forgotten. Should be fixed now. |
dartajax
left a comment
There was a problem hiding this comment.
I eyeballed some of the downloaded records and it looks pretty good to me however I might want to do some more review if this is still available for additional review on Monday.
|
NTS: Move toggle to download page, since that's where the actual change is applied to. Change the header title to reflect which choice is made. |
… in CSV, and added a toggle to switch between listed and grouped CSV output modes
…ponent to have two choices for CSV download
af12557 to
cd14a93
Compare
|
NTS: Fixes to implement: actually make the different options create the proper files, add chevron toggle icon, change tooltip to use |
…nents work and replaced title attributes with them
…aggedTerms curriculum report
|
I will test this further but I'd like to know if these reports are coded to return all sessions in the output even if the course has no tagged terms AND the session has no tagged terms - will test on my own but wanted to throw that out there for thought. I think it should return all sessions even if both fields are empty (course terms, session terms) - just so folks no nothing has been tagged - my $.02 - if that's already the case, then fantastic but like I said, I will test and find out shortly. |
|
@dartajax Neither grouped nor listed will show rows pertaining to courses or sessions with no terms (e.g. create a brand new course and do this report; the downloads will still work but it will be an empty file). Please do a review and suggest that change and i'll come back and fix it |
dartajax
left a comment
There was a problem hiding this comment.
I propose returning all sessions in the report output even if NEITHER the course NOR the sessions have any associated tagged terms.
People could use this report to determine where maybe some tagging has been missed.


Fixes ilios/ilios#6125
This creates a new variant of the Tagged Terms curriculum report. It also adds in a new toggle that only shows up when the Tagged Terms report is chosen. It defaults to Listed (one term per row, the current way of downloading the CSV data), but Grouped (multiple terms per row) is also available now.
Need to create tooltips, write tests for it, and probably workshop the toggle/config a bit.