Skip to content

Normalize disabling actions when confirming deletion#9293

Draft
michaelchadwick wants to merge 17 commits intoilios:masterfrom
michaelchadwick:frontend-normalize-disabling-actions-when-confirming-deletion
Draft

Normalize disabling actions when confirming deletion#9293
michaelchadwick wants to merge 17 commits intoilios:masterfrom
michaelchadwick:frontend-normalize-disabling-actions-when-confirming-deletion

Conversation

@michaelchadwick
Copy link
Copy Markdown
Contributor

@michaelchadwick michaelchadwick commented Apr 17, 2026

Fixes ilios/ilios#7072
Fixes ilios/ilios#7073

Relies on #9281 going through first

Sections to check

  • Course
  • Course Objective
  • Session
  • Session Objective
  • Session Offering
  • Course/Session Learning Material
  • Learner Group
  • Instructor Group
  • School Vocabulary
  • School Session Type
  • Program
  • Program Year
  • Program Year Objective
  • Curricular Inventory Report
  • Sequence Block

Additional things

  • Add/update tests

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 17, 2026

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit cc968bd
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/69fbceecaf21fb0008c5a463
😎 Deploy Preview https://deploy-preview-9293--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

❌ Visual Diff Report — FAILED

884 images compared: 230 different · 654 identical

Details

Differences (230)

File Diff % Notes
desktop-Acceptance _ Admin _ can search for users _ search results dropdown.png 0.04%
desktop-Acceptance _ course visualizations - instructors _ it renders _ .png 0.27%
desktop-Acceptance _ course visualizations - session-type _ it renders _ .png 0.27%
desktop-Acceptance _ course visualizations - session-types _ it renders _ .png 0.27%
desktop-Acceptance _ Courses _ filters by title _ default.png 0.41%
desktop-Acceptance _ Courses _ filters by title _ filterByTitle.png 0.41%
desktop-Acceptance _ Courses _ visiting _courses _ .png 0.06%
desktop-Acceptance _ Dashboard Materials _ it renders with materials in show-all mode _ .png 4.34%
desktop-Acceptance _ Dashboard Materials _ it renders with materials in show-current mode _ .png 4.31%
desktop-Acceptance _ Dashboard Materials _ mark material status _ checkbox status.png 4.31%
desktop-Acceptance _ Dashboard Materials _ mark material status _ default.png 4.31%
desktop-Acceptance _ Instructor Groups _ filters options _ .png 0.42%
desktop-Acceptance _ Instructor Groups _ User in single school _ list groups _ .png 0.42%
desktop-Acceptance _ Learner Group _ generate new subgroups _ learnerGroupId1.png 0.40%
desktop-Acceptance _ Learner Group _ generate new subgroups _ toggleNewLearnerGroupForm +2 subgroups.png 0.30%
desktop-Acceptance _ Learner Group _ generate new subgroups _ toggleNewLearnerGroupForm.png 0.31%
desktop-Acceptance _ learner-group_bulk-assignment _ finalize and save _ post-bulkAssignment.png 0.47%
desktop-Acceptance _ learner-group_bulk-assignment _ finalize and save _ pre-bulkAssignment.png 0.35%
desktop-Acceptance _ learner-group_bulk-assignment _ upload user errors _ .png 0.31%
desktop-Acceptance _ learner-group_bulk-assignment _ upload users _ upload users.png 0.10%
desktop-Acceptance _ pending user updates _ multiple schools, default school selection _ .png 0.43%
desktop-Acceptance _ pending user updates _ one school _ .png 0.43%
desktop-Acceptance _ Program Year - Cohort members _ cohort members are expanded if URL contains corresponding parameter _ .png 0.27%
desktop-Acceptance _ Program Year - Cohort members _ expand and collapse cohort members _ .png 0.28%
desktop-Acceptance _ Program Year - Competencies _ list _ .png 0.40%
… and 205 more

Download the results.

@michaelchadwick michaelchadwick force-pushed the frontend-normalize-disabling-actions-when-confirming-deletion branch from d5bb0d9 to 8379590 Compare April 21, 2026 22:02
@michaelchadwick michaelchadwick marked this pull request as ready for review April 21, 2026 22:02
@michaelchadwick michaelchadwick marked this pull request as draft April 21, 2026 22:03
@michaelchadwick michaelchadwick force-pushed the frontend-normalize-disabling-actions-when-confirming-deletion branch from 8379590 to 6e52141 Compare April 28, 2026 16:57
@michaelchadwick michaelchadwick marked this pull request as ready for review April 28, 2026 22:51
@michaelchadwick michaelchadwick marked this pull request as draft April 29, 2026 15:53
@michaelchadwick
Copy link
Copy Markdown
Contributor Author

michaelchadwick commented Apr 30, 2026

NTS: only need title, and <FaIcon> does not need a title. Also finish tests.

…sable actionable icons when confirming deletion
… icon

updated all disabled trash icon instances to have a button around the icon; did same overall treatment for lock/unlock on courses/program-years; reordered element attributes to be more consistent and added some missing ones; updated tests
@michaelchadwick michaelchadwick force-pushed the frontend-normalize-disabling-actions-when-confirming-deletion branch from cbfeb75 to cc968bd Compare May 6, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit Button Should Not Be Enabled if Deletion Process Started - Vocab Buttons That Should Not Be Active In Delete LM Context

1 participant