Normalize disabling actions when confirming deletion#9293
Draft
michaelchadwick wants to merge 17 commits intoilios:masterfrom
Draft
Normalize disabling actions when confirming deletion#9293michaelchadwick wants to merge 17 commits intoilios:masterfrom
michaelchadwick wants to merge 17 commits intoilios:masterfrom
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
❌ Visual Diff Report — FAILED884 images compared: 230 different · 654 identical DetailsDifferences (230)
Download the results. |
d5bb0d9 to
8379590
Compare
8379590 to
6e52141
Compare
Contributor
Author
|
NTS: only need |
… when confirming deletion
…sable actionable icons when confirming deletion
…s and session types
…ry reports and sequence blocks
… the cursor to a pointer
…firmation deletion; minor css class cleanup
…tions whilst confirming deletion
…xed some page-object references, too
…ourses-list tests
… icon updated all disabled trash icon instances to have a button around the icon; did same overall treatment for lock/unlock on courses/program-years; reordered element attributes to be more consistent and added some missing ones; updated tests
cbfeb75 to
cc968bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#7072
Fixes ilios/ilios#7073
Relies on #9281 going through first
Sections to check
Additional things