Hide 'skip to main content' link from visual users in Safari#9306
Merged
dartajax merged 4 commits intoilios:masterfrom May 6, 2026
Merged
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
NTS: change |
…n with our own visually-hidden existing style
jrjohnson
previously approved these changes
May 5, 2026
Member
|
Test failure is legit, need to fix the tab order of this new skip link. |
Contributor
✅ Visual Diff Approved❌ Visual Diff Report — FAILED884 images compared: 812 different · 72 identical DetailsDifferences (812)
Download the results. |
jrjohnson
approved these changes
May 6, 2026
Member
jrjohnson
left a comment
There was a problem hiding this comment.
grumble grumble, would rather use our own ID and not theirs for this, but not so much that I need to stop the work.
dartajax
approved these changes
May 6, 2026
Member
dartajax
left a comment
There was a problem hiding this comment.
nice fix - sketchy bug - tested on Safari
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#7095
Safari needs the
ember-a11y-skip-linkelement to be hidden by eitherclip(deprecated) orclip-pathto be truly hidden. Also, there may be some kind of issue with the focus-ring applied to the element when clicking the page, which causes it to "drift" down the page.