fix: accept object-subtype default for object-typed parameters#462
Merged
nahime0 merged 4 commits intoJul 10, 2026
Merged
Conversation
…type check) An interface-typed constructor-promoted property (or param) with a concrete default — `public ComponentResolverInterface $r = new NullComponentResolver()` — was rejected: "Method parameter $r expects Object(I), got Object(N)". The default is validated in the purely-syntactic schema pass, where the class/interface table isn't populated yet, so type_accepts's class_implements_interface spuriously returns false. Accept an object default for an object-typed param there (mirroring the existing enum-case leniency); a genuine mismatch still surfaces at the call site. Byte-parity regression test. AIC epic illegalstudio#483 / EC-8 (illegalstudio#491), the object-param sub-part (~14 gaps: ward-forms AlteredForm/Field/... interface-typed promoted props). (cherry picked from commit db17c17)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An object-typed parameter (or constructor-promoted property) with a concrete-subtype default is wrongly rejected:
A plain
function f(I $x)called withf(new N())works — only the default value fails.Why
validate_declared_default_typeruns in the purely-syntactic schema pass, where the class/interface table isn't populated yet, sotype_accepts'sclass_implements_interfacespuriously returns false. (The code already has the same leniency for enum-case defaults, for the same reason.)Fix
Accept an object default for an object-typed parameter in that pass; a genuine mismatch still surfaces at the call site. Byte-parity regression test (the default instantiates + dispatches). Builds standalone on
main.