feat(errors): register UnhandledMatchError as a builtin Error subclass#521
Open
chadmandoo wants to merge 1 commit into
Open
feat(errors): register UnhandledMatchError as a builtin Error subclass#521chadmandoo wants to merge 1 commit into
chadmandoo wants to merge 1 commit into
Conversation
`UnhandledMatchError` (PHP 8's error for a `match` with no matching arm and no default) is now a registered builtin class extending `Error`: newable with a message, throwable from a `match` default arm, catchable by name, and its getMessage() round-trips. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
UnhandledMatchError— PHP 8's error thrown when amatchexpression has no matching arm and nodefault— was not a registered builtin, so a program that references it (including the commondefault => throw new UnhandledMatchError(...)idiom) failed to type-check.How
Register
UnhandledMatchErroras a builtin class extendingError(the class-name list + theclass_mapinsert indeclarations.rs) and include it in the Error-family signature fixup (exception.rs), mirroringTypeError/ValueError/ArithmeticError.Test
test_unhandled_match_error_throw_and_catch— newable, throwable from amatchdefault arm, catchable by FQN, getMessage() round-trip. Byte-parity vs PHP 8.5.🤖 Generated with Claude Code