fix(types): list destructuring accepts a union/assoc RHS carrying an array member#522
Open
chadmandoo wants to merge 1 commit into
Open
Conversation
…array member `list()` / `[$a, $b] = ...` destructuring only accepted a plain `Array(T)` RHS and errored on everything else. A `?array` method return narrowed by `=== null` still types as `Union[Array, Void]` at the destructure (and an associative-array or Mixed union is an array at runtime in well-typed code). Accept an `AssocArray` RHS and a union that carries an array-like member; their elements bind as Mixed (adaptive access), the trust posture PHP applies at runtime. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
list()/[$a, $b] = ...destructuring only accepted a plainArray(T)right-hand side and errored otherwise. A common pattern was rejected:How
In
check_list_unpack, accept anAssocArrayRHS and aUnionthat carries an array-like member (Array/AssocArray/Mixed) — both are arrays at runtime in well-typed code. Their elements bind asMixed(adaptive access), the trust posture PHP applies at runtime.Test
test_list_unpack_null_narrowed_array_return— destructuring a null-narrowed?arrayreturn in a loop, byte-parity vs PHP 8.5.🤖 Generated with Claude Code