build/net462 and ci - #1
Merged
Merged
Conversation
net462 puts explicit .NET Framework support on the NuGet page for brownfield migrators. netstandard2.0 already covers the runtime, so this is about what the package listing shows. Props now layer. The root file holds what every project needs and sets IsPackable=false; src/Directory.Build.props opts back in, so tests, fixtures, and samples can no longer leak into dotnet pack. Signing stays at the root: InternalsVisibleTo from a signed assembly only resolves when the consuming test assembly carries the same strong name. Version splits into VersionPrefix and VersionSuffix so CI can stamp a different preview. Tests run on net462 too, on Windows only, so the oldest library build gets exercised. That target needs IsExternalInit for record init accessors, a real Assembly subclass in HandlerScannerTests because Castle cannot proxy Assembly on .NET Framework, and xunit.runner.visualstudio pinned at 2.8.2, the last version that targets net462. global.json pins the SDK major so local and CI builds agree.
Build and test on Windows because the net462 test target only runs there. Pack on Ubuntu, one project at a time rather than the whole solution, which would restore and build every test project again.
Setup, the rules that cannot bend (no MediatR code, nothing reflective on the dispatch path, fixed targets and dependencies), and the test conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.