feat: batch source span resolution - #76
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveMdiSourceSpans(source, spans)with one parse/projection per batchWhy
PR #75 established the source-span inverse mapping contract, but repeated singular calls reparsed a full document. This follow-up provides the batch path needed by diagnostics and decoration consumers while preserving input order and all validation/coverage/relation rules.
Validation
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo testpnpm typecheckpnpm build(including docs)pnpm --filter @illusions-lab/mdi test(83 tests)pnpm test:browser(packed Chromium, Firefox, WebKit)pnpm test:coverageRelease safety
The earlier
mainCI run was cancelled after the performance gap was identified, and its release workflow skipped. This PR must pass PR and post-mergemainCI before automatic publication.